refactor: Move push JS to META-INF/VAADIN/webapp to avoid dual serving#22830
Closed
refactor: Move push JS to META-INF/VAADIN/webapp to avoid dual serving#22830
Conversation
The vaadinPush.js file was previously placed in META-INF/resources/VAADIN/static/push/ which is automatically served by servlet containers from both the context root and through the Vaadin servlet. This created ambiguity about which path was being used. Move the push JS files to META-INF/VAADIN/webapp/VAADIN/static/push/ so they are: - NOT automatically served by the servlet container - ONLY served through the Vaadin static file handler - Located alongside other VAADIN webapp resources (themes, npm assets)
Test Results1 189 files - 107 1 189 suites - 107 1h 22m 33s ⏱️ + 7m 36s For more details on these failures and errors, see this check. Results for commit 185e450. ± Comparison against base commit db042e8. This pull request removes 228 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Member
Author
|
This apparently requires redefining from where static files are served, so let's get back to it later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The vaadinPush.js file was previously placed in META-INF/resources/VAADIN/static/push/ which is automatically served by servlet containers from both the context root and through the Vaadin servlet. This created ambiguity about which path was being used.
Move the push JS files to META-INF/VAADIN/webapp/VAADIN/static/push/ so they are: