-
Notifications
You must be signed in to change notification settings - Fork 515
Remove config unsupported by fog-libvirt #1835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove config unsupported by fog-libvirt #1835
Conversation
fog-libvirt dropped support for libvirt < 1.2.8 in version v0.13.0 This config is no longer supported nor needed
…upported by system ruby
|
A docker image containing the code from this plugin to allow testing locally without installing If you need the image with the full dev toolchain, you can instead pull: ghcr.io/vagrant-libvirt/vagrant-libvirt:pr-1835 |
|
@electrofelix anything that speaks against merging this? Ty :-) |
|
|
||
| # Make sure to allow use of the same version as Vagrant by being less specific | ||
| s.add_runtime_dependency 'nokogiri', '~> 1.6' | ||
| s.add_runtime_dependency 'nokogiri', '< 1.16' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why pin this to < 1.16 while the latest version is 1.18?
|
I saw this same issue in the Debian autopkgtest runs, so I included 5bb08ec as a patch: https://ci.debian.net/packages/v/vagrant-libvirt/testing/amd64/58775988/ |
|
This config is no longer supported, but it's needed! Removing the The warning should not be removed. This message is extremely useful in figuring out that the explicit IP is de facto not supported and will be ignored (I guess i'll be using the default virtualbox provider, which has other issues for me, but it works for my use case). Or an explicit warning/error should be added that specifying the IP is not supported. (Yes, I should use DHCP, but it requires additional configuration - did not work out of the box - and may not be feasible with all the software that I would like to use Vagrant for. I often use Vagrant for test environments consisting of several VMs that communicate to each other, the software often relying on fixed IPs. Furthermore, this will make sharing the same Vagrantfile between libvirt and virtualbox providers more complicated.) UPDATE 2025-10-24: Sorry, it was my mistake - it started working back. I'm still getting the |
fog-libvirt dropped support for libvirt < 1.2.8 in version v0.13.0 This config is no longer supported nor needed
This call generates a warning
Fixes #1831