Skip to content

Conversation

@janekzieleznicki
Copy link

fog-libvirt dropped support for libvirt < 1.2.8 in version v0.13.0 This config is no longer supported nor needed

This call generates a warning

Fixes #1831

fog-libvirt dropped support for libvirt < 1.2.8 in version v0.13.0
This config is no longer supported nor needed
@janekzieleznicki janekzieleznicki marked this pull request as ready for review November 18, 2024 18:19
@github-actions
Copy link

A docker image containing the code from this plugin to allow testing locally without installing
can be pulled from: ghcr.io/vagrant-libvirt/vagrant-libvirt:pr-1835-slim

If you need the image with the full dev toolchain, you can instead pull: ghcr.io/vagrant-libvirt/vagrant-libvirt:pr-1835

@abbbi abbbi enabled auto-merge (squash) January 5, 2025 15:23
@abbbi abbbi disabled auto-merge January 5, 2025 15:24
@abbbi abbbi enabled auto-merge January 5, 2025 15:24
@abbbi abbbi requested a review from electrofelix January 5, 2025 15:26
@abbbi
Copy link
Contributor

abbbi commented Jan 5, 2025

@electrofelix anything that speaks against merging this? Ty :-)


# Make sure to allow use of the same version as Vagrant by being less specific
s.add_runtime_dependency 'nokogiri', '~> 1.6'
s.add_runtime_dependency 'nokogiri', '< 1.16'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why pin this to < 1.16 while the latest version is 1.18?

@eighthave
Copy link
Contributor

I saw this same issue in the Debian autopkgtest runs, so I included 5bb08ec as a patch: https://ci.debian.net/packages/v/vagrant-libvirt/testing/amd64/58775988/

@aoresnik
Copy link

aoresnik commented Oct 1, 2025

This config is no longer supported, but it's needed!

Removing the libvirt_ip_command config from fog-libvirt seems to break the support for explicit IP address assignment in Vagrant private network (Vagrant 2.4.9, vagrant-libvirt 0.11.2-1, ruby-fog-libvirt 0.11.0-1 - all Debian 12 packages):

    check.vm.network :private_network, ip: "192.168.56.2", netmask: "255.255.255.0"

The warning should not be removed. This message is extremely useful in figuring out that the explicit IP is de facto not supported and will be ignored (I guess i'll be using the default virtualbox provider, which has other issues for me, but it works for my use case).

Or an explicit warning/error should be added that specifying the IP is not supported.

(Yes, I should use DHCP, but it requires additional configuration - did not work out of the box - and may not be feasible with all the software that I would like to use Vagrant for. I often use Vagrant for test environments consisting of several VMs that communicate to each other, the software often relying on fixed IPs. Furthermore, this will make sharing the same Vagrantfile between libvirt and virtualbox providers more complicated.)

UPDATE 2025-10-24: Sorry, it was my mistake - it started working back. I'm still getting the [fog][WARNING] Unrecognized arguments: libvirt_ip_command warning, but my VMs do get the specified IPs. I'm not sure what I did to fix it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fog][WARNING] Unrecognized arguments: libvirt_ip_command Logger dependency conflict with Vagrant 2.4.2

6 participants