-
-
Notifications
You must be signed in to change notification settings - Fork 28
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
[The equivalent of] cherry-picked from vapor/postgres-nio#388:
SwiftNIO has landed EventLoopGroup singletons in
2.58.0. See apple/swift-nio#2471.We should add an additional MySQLConnection connect method, that internally uses the existing one, but uses the NIO singleton:
extension MySQLConnection { static func connect( to socketAddress: SocketAddress, username: String, database: String, password: String? = nil, tlsConfiguration: TLSConfiguration? = .makeClientConfiguration(), serverHostname: String? = nil, logger: Logger = .init(label: "codes.vapor.mysql") ) -> EventLoopFuture<MySQLConnection> { Self.connect( to: socketAddress, username: username, password: password, tlsConfiguration: tlsConfiguration, serverHostname: serverHostname, on: MultiThreadedEventLoopGroup.singleton.any() ) } }
- Add API
- Remove all
EventLoopGroupusages in the README
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers