param: Move alias resolution before protected check #4324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dridi
force-pushed
the
param_alias_protected
branch
from
6ac215c to
334ea60
Compare
|
bugwash: OK, waiting for @nigoroll's review. |
nigoroll
approved these changes
May 14, 2025
bin/varnishd/mgt/mgt_param.c
Outdated
|
|
||
| orig = TRUST_ME(pp->priv); | ||
| AN(orig); | ||
| memcpy(alias, orig, sizeof *orig); |
There was a problem hiding this comment.
nitpick sizeof *alias as a "I know my buffer overflows" style checkbox?
There was a problem hiding this comment.
Fair enough, I will change the sizeof operand.
Should we have a COPY_OBJ(dest, src, magic) macro with actual type checking?
|
FTR, flexelint is happy with the tree as of f26f3f7 except for Reminder: Be aware of SQUASHMEs |
dridi
force-pushed
the
param_alias_protected
branch
from
f26f3f7 to
0e7e1ea
Compare
Instead of resolving tweaks when the function is called, this is now done in the MGT code performing the protected check. Since aliases may be used to reset a single bit of another parameter (namely vcc_feature) the default value is looked up before the alias resolution. Unfortunately, that also means resolving deprecated aliases before showing them to the user, adding a little bit of duplicated logic. Refs varnishcache#4323
The alternative could have been to mark both aliases and their original parameters as protected but there isn't always a one-to-one mapping between deprecated aliases and the parameters they point to. The old vcc_* boolean parameters turned into vcc_feature flags. Refs varnishcache#4323
dridi
force-pushed
the
param_alias_protected
branch
from
0e7e1ea to
d2b090b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
param: Move alias resolution before protected check
Instead of resolving tweaks when the function is called, this is now
done in the MGT code performing the protected check. Since aliases may
be used to reset a single bit of another parameter (namely vcc_feature)
the default value is looked up before the alias resolution.
Unfortunately, that also means resolving deprecated aliases before
showing them to the user, adding a little bit of duplicated logic.
Refs #4323