Skip to content

Commit b7c722a

Browse files
author
aMarCruz
committed
prepare for react 0.60
1 parent 9f7b0d0 commit b7c722a

File tree

7 files changed

+51
-34
lines changed

7 files changed

+51
-34
lines changed

CHANGELOG.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,20 @@
22

33
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
44

5+
## \[Unreleased]
6+
7+
### Added
8+
9+
- Updated README.md with example for flatHeights - Thanks to @donni106
10+
11+
### Changed
12+
13+
- The dependency on android.support.annotations is replaced by javax.annotation
14+
15+
### Fixed
16+
17+
- fix s.source_files regex to match RNTextSize source files: RNTextSize - Thanks to @abegehr
18+
519
## \[3.0.0] - 2019-01-10
620

721
### Added

android/build.gradle

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ def safeExtGet(prop, fallback) {
88
return rootProject.ext.hasProperty(prop) ? rootProject.ext.get(prop) : fallback
99
}
1010

11-
def _buildToolsVersion = safeExtGet('buildToolsVersion', '27.0.3')
12-
def _compileSdkVersion = safeExtGet('compileSdkVersion', 27)
13-
def _targetSdkVersion = safeExtGet('targetSdkVersion', 26)
11+
def _buildToolsVersion = safeExtGet('buildToolsVersion', '28.0.3')
12+
def _compileSdkVersion = safeExtGet('compileSdkVersion', 28)
13+
def _targetSdkVersion = safeExtGet('targetSdkVersion', 28)
1414
def _minSdkVersion = safeExtGet('minSdkVersion', 16)
1515

1616
buildscript {
@@ -19,7 +19,7 @@ buildscript {
1919
jcenter()
2020
}
2121
dependencies {
22-
classpath 'com.android.tools.build:gradle:3.1.4'
22+
classpath 'com.android.tools.build:gradle:3.4.1'
2323
}
2424
}
2525

@@ -32,7 +32,7 @@ android {
3232
defaultConfig {
3333
minSdkVersion _minSdkVersion
3434
targetSdkVersion _targetSdkVersion
35-
versionCode 3
35+
versionCode 4
3636
versionName getPackageVersion()
3737
}
3838
lintOptions {

android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip

android/src/main/java/com/github/amarcruz/rntextsize/RNTextSizeConf.java

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
import android.graphics.Typeface;
44
import android.os.Build;
5-
import android.support.annotation.NonNull;
6-
import android.support.annotation.Nullable;
75
import android.text.Layout;
86
import android.util.Log;
97

@@ -17,6 +15,9 @@
1715

1816
import java.util.Map;
1917

18+
import javax.annotation.Nonnull;
19+
import javax.annotation.Nullable;
20+
2021
@SuppressWarnings("SameParameterValue")
2122
final class RNTextSizeConf {
2223

@@ -38,9 +39,9 @@ final class RNTextSizeConf {
3839
/**
3940
* Make a Typeface from the supplied font family and style.
4041
*/
41-
@NonNull
42+
@Nonnull
4243
static Typeface getFont(
43-
@NonNull final ReactApplicationContext context,
44+
@Nonnull final ReactApplicationContext context,
4445
@Nullable String family,
4546
final int style
4647
) {
@@ -76,7 +77,7 @@ static boolean supportUpperCaseTransform() {
7677
* @param options User options
7778
* @param forText This will be used for measure text?
7879
*/
79-
RNTextSizeConf(@NonNull final ReadableMap options, final boolean forText) {
80+
RNTextSizeConf(@Nonnull final ReadableMap options, final boolean forText) {
8081
mOpts = options;
8182

8283
allowFontScaling = forText && getBooleanOrTrue("allowFontScaling");
@@ -89,27 +90,27 @@ static boolean supportUpperCaseTransform() {
8990
letterSpacing = supportLetterSpacing() ? getFloatOrNaN("letterSpacing") : Float.NaN;
9091
}
9192

92-
boolean has(@NonNull final String name) {
93+
boolean has(@Nonnull final String name) {
9394
return mOpts.hasKey(name);
9495
}
9596

96-
boolean getBooleanOrTrue(@NonNull final String name) {
97+
boolean getBooleanOrTrue(@Nonnull final String name) {
9798
return !mOpts.hasKey(name) || mOpts.getBoolean(name);
9899
}
99100

100-
Integer getIntOrNull(@NonNull final String name) {
101+
Integer getIntOrNull(@Nonnull final String name) {
101102
return mOpts.hasKey(name)
102103
? mOpts.getInt(name) : null;
103104
}
104105

105106
@Nullable
106-
String getString(@NonNull final String name) {
107+
String getString(@Nonnull final String name) {
107108
return mOpts.hasKey(name)
108109
? mOpts.getString(name) : null;
109110
}
110111

111112
@Nullable
112-
ReadableArray getArray(@NonNull final String name) {
113+
ReadableArray getArray(@Nonnull final String name) {
113114
return mOpts.hasKey(name) && mOpts.getType(name) == ReadableType.Array
114115
? mOpts.getArray(name) : null;
115116
}
@@ -152,7 +153,7 @@ int getTextBreakStrategy() {
152153
return Layout.BREAK_STRATEGY_HIGH_QUALITY;
153154
}
154155

155-
private float getFloatOrNaN(@NonNull final String name) {
156+
private float getFloatOrNaN(@Nonnull final String name) {
156157
return mOpts.hasKey(name) ? (float) mOpts.getDouble(name) : Float.NaN;
157158
}
158159

android/src/main/java/com/github/amarcruz/rntextsize/RNTextSizeModule.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
import android.graphics.Paint;
55
import android.graphics.Typeface;
66
import android.os.Build;
7-
import android.support.annotation.NonNull;
8-
import android.support.annotation.Nullable;
97
import android.text.BoringLayout;
108
import android.text.Layout;
119
import android.text.SpannableString;
@@ -30,6 +28,9 @@
3028
import java.util.Collections;
3129
import java.util.List;
3230

31+
import javax.annotation.Nonnull;
32+
import javax.annotation.Nullable;
33+
3334
class RNTextSizeModule extends ReactContextBaseJavaModule {
3435
private static final String TAG = "RNTextSize";
3536
private static final float SPACING_ADDITION = 0f;
@@ -401,11 +402,11 @@ private WritableMap makeFontSpecs(String suffix, int fontSize, double letterSpac
401402
return makeFontSpecs(suffix, fontSize, letterSpacing, false);
402403
}
403404

404-
@NonNull
405+
@Nonnull
405406
private WritableMap fontInfoFromTypeface(
406-
@NonNull final TextPaint textPaint,
407-
@NonNull final Typeface typeface,
408-
@NonNull final RNTextSizeConf conf
407+
@Nonnull final TextPaint textPaint,
408+
@Nonnull final Typeface typeface,
409+
@Nonnull final RNTextSizeConf conf
409410
) {
410411
// Info is always in unscaled values
411412
final float density = getCurrentDensity();
@@ -444,7 +445,7 @@ private float getCurrentDensity() {
444445
* Set the font names in assets/fonts into the target array.
445446
* @param destArr Target
446447
*/
447-
private void getFontsInAssets(@NonNull WritableArray destArr) {
448+
private void getFontsInAssets(@Nonnull WritableArray destArr) {
448449
String[] srcArr = fontsInAssets;
449450

450451
if (srcArr == null) {
@@ -475,8 +476,8 @@ private void getFontsInAssets(@NonNull WritableArray destArr) {
475476
}
476477

477478
private void addFamilyToArray(
478-
@NonNull final List<String> outArr,
479-
@NonNull final String spec
479+
@Nonnull final List<String> outArr,
480+
@Nonnull final String spec
480481
) {
481482
for (String ext : FILE_EXTENSIONS) {
482483
if (spec.endsWith(ext)) {

android/src/main/java/com/github/amarcruz/rntextsize/RNTextSizeSpannedText.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,23 @@
33
import android.annotation.TargetApi;
44
import android.graphics.Typeface;
55
import android.os.Build;
6-
import android.support.annotation.NonNull;
76
import android.text.Spannable;
87
import android.text.TextPaint;
98
import android.text.style.AbsoluteSizeSpan;
109
import android.text.style.MetricAffectingSpan;
1110

1211
import com.facebook.react.bridge.ReactApplicationContext;
1312

13+
import javax.annotation.Nonnull;
14+
1415
final class RNTextSizeSpannedText {
1516

1617
RNTextSizeSpannedText() {}
1718

1819
static Spannable spannedFromSpecsAndText(
19-
@NonNull final ReactApplicationContext context,
20-
@NonNull final RNTextSizeConf conf,
21-
@NonNull final Spannable text
20+
@Nonnull final ReactApplicationContext context,
21+
@Nonnull final RNTextSizeConf conf,
22+
@Nonnull final Spannable text
2223
) {
2324

2425
//final SpannableString str = new SpannableString(text);
@@ -87,7 +88,7 @@ public void updateDrawState(TextPaint paint) {
8788
}
8889

8990
@Override
90-
public void updateMeasureState(TextPaint paint) {
91+
public void updateMeasureState(@Nonnull TextPaint paint) {
9192
apply(paint);
9293
}
9394

@@ -114,7 +115,7 @@ public void updateDrawState(TextPaint ds) {
114115
}
115116

116117
@Override
117-
public void updateMeasureState(TextPaint paint) {
118+
public void updateMeasureState(@Nonnull TextPaint paint) {
118119
apply(paint, mTypeface);
119120
}
120121

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-text-size",
3-
"version": "3.0.0",
3+
"version": "4.0.0-rc.1",
44
"description": "Measure text accurately before laying it out and get font information from your App",
55
"main": "index.js",
66
"keywords": [
@@ -25,6 +25,6 @@
2525
"clean": "rm -rf $TMPDIR/react-* && watchman watch-del-all && cd android && ./gradlew clean"
2626
},
2727
"peerDependencies": {
28-
"react-native": ">=0.57.0"
28+
"react-native": ">=0.59.0"
2929
}
3030
}

0 commit comments

Comments
 (0)