Fix bug and add sbom #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `dotnet.yml` to install Microsoft SBom tool. - Added null key test methods in `ServiceLocatorTests.cs`. - Modified `MSDependencyInjectionServiceLocator.cs` to handle null/empty keys. - Reformatted project file and added `<GenerateSBOM>` property. - Added package reference for `Microsoft.Sbom.Targets`.
Modified GetInstance methods in MSDependencyInjectionServiceLocator.cs to use FirstOrDefault for null handling. Added a new test method GetInstance_Generic_WithNullKey_NotRegisterClass in ServiceLocatorTests.cs to verify behavior. Introduced IAmNotUsed interface in vb2ae.ServiceLocator.MSDependencyInjection.Tests.Models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
vb2ae.ServiceLocator.MSDependencyInjectionproject, focusing on adding support for null keys, incorporating the Microsoft SBom tool, and updating dependencies. The most important changes are summarized below:Support for null keys:
vb2ae.ServiceLocator.MSDependencyInjection/MSDependencyInjectionServiceLocator.cs: ModifiedGetInstancemethods to handle null keys by returning the first available instance of the requested service type. [1] [2]vb2ae.ServiceLocator.MSDependencyInjection.Tests/ServiceLocatorTests.cs: Added new test cases to verify the behavior ofGetInstancemethods when the key is null. [1] [2]Incorporation of Microsoft SBom tool:
.github/workflows/dotnet.yml: Added a step to install the Microsoft SBom tool in the GitHub Actions workflow.vb2ae.ServiceLocator.MSDependencyInjection/vb2ae.ServiceLocator.MSDependencyInjection.csproj: Enabled SBOM generation by adding theGenerateSBOMproperty and included theMicrosoft.Sbom.Targetspackage. [1] [2]Codebase updates:
vb2ae.ServiceLocator.MSDependencyInjection/MSDependencyInjectionServiceLocator.cs: Added missingusing System.Linq;directive.vb2ae.ServiceLocator.MSDependencyInjection.Tests/Models/IAmNotUsed.cs: Added a new internal interfaceIAmNotUsedfor testing purposes.Closes Add Sbom to nuget package #30