fix: When defaultHomePage is inconsistent with user.homePath, the pa…

[zwtvip]

fix: #6188

Summary by CodeRabbit

• Refactor
  • Improved the logic for determining redirect paths during navigation, resulting in clearer and more predictable routing behavior for users.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 969e28a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

"""

Walkthrough

The conditional logic for determining the redirectPath in the router guard was refactored from a nested ternary expression to a clear if-else chain, introducing an explicit check for when the target path matches the user's home path. No changes were made to exported or public entity declarations.

Changes

File(s)	Change Summary
playground/src/router/guard.ts	Refactored redirectPath assignment from nested ternary to explicit if-else, adding a user home path condition.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant RouterGuard
    participant UserInfo

    User->>RouterGuard: Navigates to a route
    RouterGuard->>UserInfo: Retrieves user info (homePath)
    RouterGuard->>RouterGuard: Determines redirectPath using if-else logic
    RouterGuard-->>User: Redirects to computed redirectPath

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Fix redirect logic when defaultHomePage and user.homePath differ so that refreshing defaultHomePage does not redirect to user.homePath (#6188)	✅

Possibly related PRs

• refactor: modify the default homepage path loaded from the preference… #6099: Adjusts how the default home path is referenced in the router guard, related to redirect handling logic.

Suggested reviewers

• mynetfan
• anncwb
• jinmao88
• vince292007

Poem

In the warren of routes, a path was unclear,
Now the rabbit hops with logic sincere.
No more sudden leaps to a home unplanned,
Just tidy if-else, as the routers demand.
With a twitch of the nose and a bug now gone,
The code hops forward, smoothly on! 🐇✨
"""

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7596ffa and 969e28a.

📒 Files selected for processing (1)

• playground/src/router/guard.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• playground/src/router/guard.ts

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: post-update (windows-latest)
• GitHub Check: post-update (ubuntu-latest)
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Check (ubuntu-latest)
• GitHub Check: Check (windows-latest)
• GitHub Check: Lint (windows-latest)
• GitHub Check: Lint (ubuntu-latest)
• GitHub Check: Test (windows-latest)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 96a10ca and 7596ffa.

📒 Files selected for processing (1)

• playground/src/router/guard.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: Check (windows-latest)
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Check (ubuntu-latest)
• GitHub Check: Test (windows-latest)
• GitHub Check: Lint (ubuntu-latest)
• GitHub Check: Lint (windows-latest)
• GitHub Check: post-update (ubuntu-latest)
• GitHub Check: post-update (windows-latest)