Skip to content

Fix ecdsa_raw verify and recover #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ecdsa_raw verify and recover #146

wants to merge 1 commit into from

Conversation

wizardofozzie
Copy link
Contributor

ecdsa v value fix (tests working!)

@wizardofozzie
Update main.py
25c2553 
ecdsa v value fix (tests working!)
@wizardofozzie
Copy link
Contributor Author

v = 0 fails on ecdsa_raw_recover and ecdsa_raw_verify (False and ValueError, respectively) since v value is lost with DER encoding

@wizardofozzie wizardofozzie changed the title Update main.py Fix ecdsa_raw verify and recover Aug 1, 2016
@wizardofozzie
Copy link
Contributor Author

@vbuterin this code fixes failing tests

@reiven
Copy link
Contributor

reiven commented Oct 14, 2016

@vbuterin can this be merged, so tests stops failing? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wizardofozzie @reiven