-
Notifications
You must be signed in to change notification settings - Fork 14
2404 sdkv3 transaction request in walletclient #2449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sdk-v3
Are you sure you want to change the base?
2404 sdkv3 transaction request in walletclient #2449
Conversation
Signed-off-by: Luca Nicola Debiasi <63785793+lucanicoladebiasi@users.noreply.github.com>
…-and-signer' into 2311-sdkv3---transaction-request-and-signer
…sdkv3---transaction-request-in-walletclient
…t-in-walletclient # Conflicts: # packages/sdk/src/thor/thorest/model/TransactionRequest.ts # packages/sdk/src/thor/thorest/signer/RLPCodec.ts # packages/sdk/tests/thor/thorest/signer/RLPCodec.unit.test.ts
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
The Viem compatible
packages/sdk/src/viem/clients/WalletClient.ts
uses the original Viem account to sign according Thor rules, supporting the "transaction request paradigm.The
signTransactionRequest
andsendTransaction
methods acceptPrepareTransactionRequestRequest
Viem compatible transaction request intended to be sponsored or not, the wallet signs as origin;TransactionRequest
Thor compatible transaction request, intended to be sponsored or not, the wallet signs as origin;SignedTransactionRequest
to be sponsored the wallet signs as gas payer.The
packages/sdk/src/thor/thorest/transactions/model/Transaction.ts
and related classes and interfaces are now obsolete and ready to be removed.Fixes #2404
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
yarn test:unit
yarn test:solo
Test Configuration: