Skip to content

Conversation

lucanicoladebiasi
Copy link
Collaborator

Description

The Viem compatible packages/sdk/src/viem/clients/WalletClient.ts uses the original Viem account to sign according Thor rules, supporting the "transaction request paradigm.

The signTransactionRequest and sendTransaction methods accept

  • PrepareTransactionRequestRequest Viem compatible transaction request intended to be sponsored or not, the wallet signs as origin;
  • TransactionRequest Thor compatible transaction request, intended to be sponsored or not, the wallet signs as origin;
  • SignedTransactionRequest to be sponsored the wallet signs as gas payer.

The packages/sdk/src/thor/thorest/transactions/model/Transaction.ts and related classes and interfaces are now obsolete and ready to be removed.

Fixes #2404

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • yarn test:unit
  • yarn test:solo

Test Configuration:

  • Node.js Version: v24.0.0
  • Yarn Version: 1.22.22

lucanicoladebiasi and others added 29 commits August 30, 2025 12:30
Signed-off-by: Luca Nicola Debiasi <63785793+lucanicoladebiasi@users.noreply.github.com>
…-and-signer' into 2311-sdkv3---transaction-request-and-signer
…t-in-walletclient

# Conflicts:
#	packages/sdk/src/thor/thorest/model/TransactionRequest.ts
#	packages/sdk/src/thor/thorest/signer/RLPCodec.ts
#	packages/sdk/tests/thor/thorest/signer/RLPCodec.unit.test.ts
Copy link
Contributor

coderabbitai bot commented Sep 7, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 2404-sdkv3---transaction-request-in-walletclient

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@claytonneal claytonneal changed the base branch from main to sdk-v3 September 8, 2025 07:49
@frank0170 frank0170 changed the title 2404 sdkv3 transaction request in walletclient 2407 sdkv3 transaction request in walletclient Sep 18, 2025
@victhorbi victhorbi linked an issue Sep 18, 2025 that may be closed by this pull request
@frank0170 frank0170 changed the title 2407 sdkv3 transaction request in walletclient 2404 sdkv3 transaction request in walletclient Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants