-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(core): Save order lines after applying taxes #3668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(core): Save order lines after applying taxes #3668
Conversation
ref: Hydrating an order resets taxsummary vendure-ecommerce#3556
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
ref: Hydrating an order resets taxsummary #3556
Description
Draft PR to address an issue where taxSummary gets reset after hydrating the order entity in a custom ShippingEligibilityChecker.
This fix targets a specific edge case and is intended as a temporary workaround. The goal is to verify if any tests fail and whether this can be used to unblock the issue for now.
Breaking changes
Does this PR include any breaking changes we should be aware of?
Screenshots
You can add screenshots here if applicable.
Checklist
📌 Always:
👍 Most of the time: