Skip to content

Commit a95611f

Browse files
authored
feat(next-swc): force teardown heap profiler if exists (#47769)
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> ### What? This is followup for #47729, for some cases (mostly test) it forces child process so normal teardown to flush may not being called. PR enables force flushing for those process event. Same as original changes, for the normal next-swc this won't affect anything.
1 parent a9e4b79 commit a95611f

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

packages/next/src/cli/next-dev.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ const nextDev: CliCommand = async (argv) => {
219219

220220
const { validateTurboNextConfig } =
221221
require('../lib/turbopack-warning') as typeof import('../lib/turbopack-warning')
222-
const { loadBindings, __isCustomTurbopackBinary } =
222+
const { loadBindings, __isCustomTurbopackBinary, teardownHeapProfiler } =
223223
require('../build/swc') as typeof import('../build/swc')
224224
const { eventCliSession } =
225225
require('../telemetry/events/version') as typeof import('../telemetry/events/version')
@@ -286,6 +286,13 @@ const nextDev: CliCommand = async (argv) => {
286286
if (!isCustomTurbopack) {
287287
await telemetry.flush()
288288
}
289+
290+
// There are some cases like test fixtures teardown that normal flush won't hit.
291+
// Force flush those on those case, but don't wait for it.
292+
;['SIGTERM', 'SIGINT', 'beforeExit', 'exit'].forEach((event) =>
293+
process.on(event, () => teardownHeapProfiler())
294+
)
295+
289296
return server
290297
} else {
291298
let cleanupFns: (() => Promise<void> | void)[] = []

0 commit comments

Comments
 (0)