Enable pnpm dependency caching in e2e deploy tests#88953
Merged
Conversation
|
Cursor Agent can help with this pull request. Just |
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
eps1lon
commented
Jan 26, 2026
eps1lon
changed the title
Collaborator
Tests Passed |
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **432 kB** → **432 kB** ✅ -42 B82 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
|
This adds pnpm dependency caching to build_reusable.yml for jobs that run on GitHub-hosted ubuntu-latest runners (like the e2e deploy tests). The caching pattern follows the same approach used in build_and_deploy.yml, create_release_branch.yml, and trigger_release.yml: - Get the pnpm store path - Cache it using actions/cache@v4 with a key based on pnpm-lock.yaml hash This will speed up pnpm install for jobs like test_e2e_deploy_release.yml that pass runs_on_labels: '["ubuntu-latest"]'. Co-authored-by: sebastian.silbermann <sebastian.silbermann@vercel.com>
This reverts commit 58fc623.
Add enablePnpmCache input to build_reusable.yml and enable it in test_e2e_deploy_release.yml for the test-deploy job. This caches the pnpm store between workflow runs, speeding up pnpm install for GitHub-hosted ubuntu-latest runners. The caching pattern follows the same approach used in build_and_deploy.yml, create_release_branch.yml, and trigger_release.yml. Co-authored-by: sebastian.silbermann <sebastian.silbermann@vercel.com>
Add check for ubuntu-latest in runs_on_labels to ensure pnpm caching only runs on GitHub-hosted runners. Self-hosted runners have their own persistent storage and don't need actions/cache. Co-authored-by: sebastian.silbermann <sebastian.silbermann@vercel.com>
Remove the explicit enablePnpmCache option and instead automatically enable pnpm store caching when runs_on_labels contains 'ubuntu-latest'. This way any job using build_reusable.yml on GitHub-hosted runners will benefit from pnpm caching without needing to remember to enable it. Co-authored-by: sebastian.silbermann <sebastian.silbermann@vercel.com>
Aligns with the pattern used in other workflows (build_and_deploy.yml, create_release_branch.yml, trigger_release.yml) that explain restore-keys is avoided to prevent indefinite cache growth. Co-authored-by: sebastian.silbermann <sebastian.silbermann@vercel.com>
Use runner.environment == 'github-hosted' instead of checking runs_on_labels for 'ubuntu-latest'. This is more reliable as it directly checks the runner type rather than inferring from labels. Co-authored-by: sebastian.silbermann <sebastian.silbermann@vercel.com>
eps1lon
force-pushed
the
cursor/e2e-deploy-pnpm-caching-d170
branch
from
3edcdbd to
d6d5a70
Compare
ijjk
reviewed
Jan 26, 2026
|
|
||
| - name: Cache pnpm store | ||
| if: ${{ runner.environment == 'github-hosted' }} | ||
| uses: actions/cache@v4 |
Member
There was a problem hiding this comment.
Has actions/cache gotten more reliable? We previously saw restoring from cache causing slower perf than just installing directly in GitHub's runners, the cache would also randomly cause workflows to fail from transient errors.
Member
Author
There was a problem hiding this comment.
I've never seen a fresh download be faster than a cached install tbh. Maybe it's only slower on self-hosted runners which this change doesn't affect.
Member
There was a problem hiding this comment.
This was way back before we had self hosted runners
ijjk
approved these changes
Jan 26, 2026
Member
Author
|
Can't think of an easy A/B testing setup. Will just look at before/after times (after is cache step + install step). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds pnpm dependency caching to the e2e deploy test workflow. Basically all workflows using build_reusable in a GitHub hosted runners now get pnpm dependency caching. Self-hosted runners relied on the persisted worker environment.
It's also nice for forks/mirrors that use GitHub-hosted runners.
For e2e deploy test this is mostly relevant for a retry. Right now the lockfile changes for every release anyway since we have to use exact versions in the package.json (which change for every release). Ideally we'd use
workspace:*andpnpm publishto avoid lockfile changes on release.test plan
Slack Thread