Skip to content

fix: 🐛 Prevent mutexes from deadlocking kernel #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: 🐛 Prevent mutexes from deadlocking kernel #34

wants to merge 3 commits into from

Conversation

ion098
Copy link
Contributor

@ion098 ion098 commented Sep 18, 2024

Describe the changes this PR makes. Why should it be merged?

This function changes the mutex implementation to acquire/release the critical section when locking/unlocking a mutex, preventing deadlocks in interrupt handlers.

Additional Context

doinkythederp
doinkythederp requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@doinkythederp doinkythederp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these changes mean you can have 2 mutex guards at the same time which is unsound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doinkythederp doinkythederp Awaiting requested review from doinkythederp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ion098 @doinkythederp