moved the dir helper function to atom level

Author: realestestate

code/game/atoms.dm

@@ -1176,3 +1176,31 @@ its easier to just keep the beam vertical.
 
 /atom/proc/silicate_act(var/atom/A, var/mob/user)
 	return FALSE
+
+//bit operation that ensures dir is cardinal facing(N,E,S,W) just in case it's not.
+/atom/proc/force_cardinal_dir()
+	dir = dir^(dir&(dir-1))
+
+//Returns dir as a string
+/atom/proc/get_dir_as_string(var/atom/target)
+	if(src.loc && target.loc)
+		var/direction = get_dir(src.loc, target.loc)
+		switch(direction)
+			if(NORTH)
+				return "north"
+			if(SOUTH)
+				return "south"
+			if(WEST)
+				return "west"
+			if(EAST)
+				return "east"
+			if(NORTHEAST)
+				return "northeast"
+			if(NORTHWEST)
+				return "northwest"
+			if(SOUTHEAST)
+				return "southeast"
+			if(SOUTHWEST)
+				return "southwest"
+	else
+		return null

code/game/machinery/machinery.dm

@@ -917,30 +917,3 @@ Class Procs:
 				table_shift()
 		else
 			table_unshift()
-
-/obj/machinery/proc/cardinalize_dir()
- //bit operation that ensures cardinal facing in the off chance its not.
-	dir = dir^(dir&(dir-1))
-
-/obj/machinery/proc/getDirString(var/atom/target)
-	if(src.loc && target.loc)
-		var/direction = get_dir(src.loc, target.loc)
-		switch(direction)
-			if(NORTH)
-				return "NORTH"
-			if(SOUTH)
-				return "SOUTH"
-			if(WEST)
-				return "WEST"
-			if(EAST)
-				return "EAST"
-			if(NORTHEAST)
-				return "NORTHEAST"
-			if(NORTHWEST)
-				return "NORTHWEST"
-			if(SOUTHEAST)
-				return "SOUTHEAST"
-			if(SOUTHWEST)
-				return "SOUTHWEST"
-	else
-		return null

code/game/mecha/mech_bay.dm

@@ -88,11 +88,11 @@
 /obj/machinery/mech_bay_recharge_floor/examine(mob/user)
 	. = ..()
 	if(recharge_port)
-		var/direction = getDirString(recharge_port)
-		to_chat(user,"<span class='notice'>Linked to \the [recharge_port] at the [direction].</span>")
+		var/direction = get_dir_as_string(recharge_port)
+		to_chat(user,"<span class='notice'>Linked to \the [recharge_port] at the [uppertext(direction)].</span>")
 	if(recharge_console)
-		var/direction = getDirString(recharge_console)
-		to_chat(user,"<span class='notice'>Linked to \the [recharge_console] at the [direction].</span>")
+		var/direction = get_dir_as_string(recharge_console)
+		to_chat(user,"<span class='notice'>Linked to \the [recharge_console] at the [uppertext(direction)].</span>")
 
 /obj/machinery/mech_bay_recharge_floor/proc/locate_and_link_port()
 	if(recharge_port)//we already have a port
@@ -102,7 +102,7 @@
 			continue
 		if(potential_recharge_port.recharge_floor) //it is already linked to another floor. do not link to it.
 			continue
-		potential_recharge_port.cardinalize_dir()
+		potential_recharge_port.force_cardinal_dir()
 		if(src in get_step(potential_recharge_port, potential_recharge_port.dir).contents) 	//check if dir of recharge port matches mechbay floor
 			recharge_port = potential_recharge_port
 			recharge_port.recharge_floor = src
@@ -211,11 +211,11 @@
 /obj/machinery/mech_bay_recharge_port/examine(mob/user)
 	. = ..()
 	if(recharge_floor)
-		var/direction = getDirString(recharge_floor)
-		to_chat(user,"<span class='notice'>Linked to \the [recharge_floor] at the [direction].</span>")
+		var/direction = get_dir_as_string(recharge_floor)
+		to_chat(user,"<span class='notice'>Linked to \the [recharge_floor] at the [uppertext(direction)].</span>")
 	if(recharge_console)
-		var/direction = getDirString(recharge_console)
-		to_chat(user,"<span class='notice'>Linked to \the [recharge_console] at the [direction].</span>")
+		var/direction = get_dir_as_string(recharge_console)
+		to_chat(user,"<span class='notice'>Linked to \the [recharge_console] at the [uppertext(direction)].</span>")
 
 /obj/machinery/mech_bay_recharge_port/Destroy()
 	delink_devices()
@@ -232,7 +232,7 @@
 /obj/machinery/mech_bay_recharge_port/proc/locate_and_link_station()
 	if(recharge_floor) // we already have a station
 		return 0
-	cardinalize_dir()
+	force_cardinal_dir()
 	for(var/obj/machinery/mech_bay_recharge_floor/potential_recharge_floor in get_step(src,dir))
 		if(!potential_recharge_floor.anchored)
 			continue
@@ -467,11 +467,11 @@
 /obj/machinery/computer/mech_bay_power_console/examine(mob/user)
 	. = ..()
 	if(recharge_floor)
-		var/direction = getDirString(recharge_floor)
-		to_chat(user,"<span class='notice'>Linked to \the [recharge_floor] at the [direction].</span>")
+		var/direction = get_dir_as_string(recharge_floor)
+		to_chat(user,"<span class='notice'>Linked to \the [recharge_floor] at the [uppertext(direction)].</span>")
 	if(recharge_port)
-		var/direction = getDirString(recharge_port)
-		to_chat(user,"<span class='notice'>Linked to \the [recharge_port] at the [direction].</span>")
+		var/direction = get_dir_as_string(recharge_port)
+		to_chat(user,"<span class='notice'>Linked to \the [recharge_port] at the [uppertext(direction)].</span>")
 
 
 /obj/machinery/computer/mech_bay_power_console/wrenchAnchor()