ID Flashing (thanks to Goonstation for sprites) (#38230)

* ID Flashing

* Alters pixel offsets

* Refactor code to be cleaner for flashing

* Final updates

Author: spess-empyrean

code/datums/flash_animations.dm

@@ -0,0 +1,105 @@
+#define FLASH_ID_ANIM  "flash_id_anim"
+#define FLASH_BADGE_ANIM "flash_badge_anim"
+#define FLASH_BADGE_CORD_ANIM "flash_badge_cord_anim"
+
+
+var/flash_pixel_offsets = list(
+	"base"=list(
+		FLASH_ID_ANIM=list(
+			"hand_shape" = "id",
+			"left"  = list("x"=  4, "y" =  -3),
+			"right" = list("x"= -5, "y" =  0)
+		),
+		FLASH_BADGE_ANIM=list(
+			"hand_shape" = "badge",
+			"left"  = list("x"=  7, "y" =  -1),
+			"right" = list("x"= -7, "y" =  -2)
+		),
+		FLASH_BADGE_CORD_ANIM=list(
+			"hand_shape" = "badge",
+			"left"  = list("x"=  7, "y" =  -1),
+			"right" = list("x"= -7, "y" =  -2)
+		)
+	),
+	"vox"=list(
+		FLASH_ID_ANIM=list(
+			"hand_shape" = "id",
+			"left"  = list("x"=  5, "y" =  -3),
+			"right" = list("x"= -5, "y" =  -1)
+		),
+		FLASH_BADGE_ANIM=list(
+			"hand_shape" = "badge",
+			"left"  = list("x"=  8, "y" =  -2),
+			"right" = list("x"= -7, "y" =  -2)
+		),
+		FLASH_BADGE_CORD_ANIM=list(
+			"hand_shape" = "badge",
+			"left"  = list("x"=  8, "y" =  -4),
+			"right" = list("x"= -7, "y" =  -6)
+		)
+	)
+)
+
+/proc/flash_object_animation(var/mob/user, var/obj/item/target, var/animation_type=FLASH_ID_ANIM)
+	// Credit to pgmzeta of Goonstation for the base hand flash sprite under CC-BY-NC-SA. Modifications made so that
+	// the pixels align better with /vg/'s diagonal card as well as to fit other item shapes and other species.
+	var/hand_flash_icon_state
+	var/pixel_x_offset
+	var/pixel_y_offset
+
+	var/species_tag = "base"
+	if(isvox(user))
+		species_tag = "vox"
+	var/hand_shape = flash_pixel_offsets[species_tag][animation_type]["hand_shape"]
+
+	if(user.active_hand == 1)
+		hand_flash_icon_state = "hold_[hand_shape]_[species_tag]_right"
+		pixel_x_offset = flash_pixel_offsets[species_tag][animation_type]["right"]["x"]
+		pixel_y_offset = flash_pixel_offsets[species_tag][animation_type]["right"]["y"]
+	else
+		hand_flash_icon_state = "hold_[hand_shape]_[species_tag]_left"
+		pixel_x_offset = flash_pixel_offsets[species_tag][animation_type]["left"]["x"]
+		pixel_y_offset = flash_pixel_offsets[species_tag][animation_type]["left"]["y"]
+
+	var/hand_color = rgb(255, 202, 149)
+	if(ishuman(user))
+		var/mob/living/carbon/human/h = user
+
+		var/obj/item/equipped_external_suit = h.wear_suit
+		if(istype(equipped_external_suit) && equipped_external_suit.body_parts_covered & HANDS)
+
+			hand_color = AverageColor(getFlatIcon(equipped_external_suit))
+		else
+			var/obj/item/equipped_gloves = h.gloves
+			if(istype(equipped_gloves) && equipped_gloves.body_parts_covered & HANDS)
+				hand_color = AverageColor(getFlatIcon(equipped_gloves))
+			else
+				hand_color = h.get_skin_color()
+
+	var/image/hand_image = image("icon"='icons/effects/effects.dmi', "icon_state"=hand_flash_icon_state, "layer"=MOB_LAYER+1)
+	hand_image.color = hand_color
+	hand_image.pixel_x += pixel_x_offset
+	hand_image.pixel_y += pixel_y_offset
+	user.dir = SOUTH
+
+	var/cached_vis_flags = target.vis_flags
+	target.vis_flags |= (VIS_INHERIT_ID | VIS_INHERIT_PLANE | VIS_INHERIT_LAYER)
+	target.pixel_x += pixel_x_offset
+	target.pixel_y += pixel_y_offset
+
+	user.vis_contents += target
+	user.overlays += hand_image
+
+	user.delayNextMove(0.5 SECONDS)
+	playsound(user, 'sound/weapons/whip_crack.ogg', 40, 1)
+
+	spawn(5)
+		if(user != null)
+			user.overlays -= hand_image
+
+		if(target != null)
+			if(user != null)
+				user.vis_contents -= target
+			target.vis_flags = cached_vis_flags
+			target.pixel_x -= pixel_x_offset
+			target.pixel_y -= pixel_y_offset

code/game/objects/items/weapons/cards_ids.dm

@@ -248,10 +248,11 @@ var/list/global/id_cards = list()
 /obj/item/weapon/card/id/attack_self(var/mob/user)
 	if(user.attack_delayer.blocked())
 		return
-	user.visible_message("[user] shows you: [bicon(src)] [name]: assignment: [assignment]",\
-		"You flash your ID card: [bicon(src)] [name]: assignment: [assignment]")
-	user.delayNextAttack(1 SECONDS)
+	user.visible_message("[user] shows you: [bicon(src)] [name]. Assignment: [assignment]",\
+		"You flash your ID card: [bicon(src)] [name]. Assignment: [assignment]")
+	user.delayNextAttack(0.5 SECONDS)
 	add_fingerprint(user)
+	flash_object_animation(user, src, FLASH_ID_ANIM)
 
 /obj/item/weapon/card/id/GetAccess()
 	if(arcanetampered)

code/libs/IconProcs/IconProcs.dm

@@ -479,6 +479,12 @@
 
 	return rgb(r, g, b)
 
+/proc/SubRGB(rgb1, rgb2, amount)
+	var/list/RGB1 = rgb2num(rgb1)
+	var/list/RGB2 = rgb2num(rgb2)
+
+	return rgb(clamp(RGB1[1] - RGB2[1], 0, 255), clamp(RGB1[2] - RGB2[2], 0, 255), clamp(RGB1[3] - RGB2[3], 0, 255))
+
 /proc/BlendRGBasHSV(rgb1, rgb2, amount)
 	return HSVtoRGB(RGBtoHSV(rgb1), RGBtoHSV(rgb2), amount)
 

code/modules/clothing/accessories/accessory.dm

@@ -306,18 +306,23 @@
 	slot_flags = SLOT_BELT
 
 	var/stored_name = null
+	var/flash_animation = FLASH_BADGE_ANIM
 
 /obj/item/clothing/accessory/holobadge/cord
 	icon_state = "holobadge-cord"
 	_color = "holobadge-cord"
 	slot_flags = SLOT_MASK
+	flash_animation = FLASH_BADGE_CORD_ANIM
 
 /obj/item/clothing/accessory/holobadge/attack_self(mob/user as mob)
 	if(!stored_name)
 		to_chat(user, "Waving around a badge before swiping an ID would be pretty pointless.")
 		return
 	if(isliving(user))
+		user.delayNextAttack(0.5 SECONDS)
+		add_fingerprint(user)
 		user.visible_message("<span class='warning'>[user] displays their Nanotrasen Internal Security Legal Authorization Badge.\nIt reads: [stored_name], NT Security.</span>","<span class='warning'>You display your Nanotrasen Internal Security Legal Authorization Badge.\nIt reads: [stored_name], NT Security.</span>")
+		flash_object_animation(user, src, flash_animation)
 
 /obj/item/clothing/accessory/holobadge/attackby(var/obj/item/O as obj, var/mob/user as mob)
 

code/modules/mob/living/carbon/human/update_icons.dm

@@ -294,6 +294,26 @@ var/global/list/damage_icon_parts = list()
 	if(update_icons)
 		update_icons()
 
+/mob/living/carbon/human/proc/get_skin_color()
+	var/husk = (M_HUSK in mutations)
+	var/hulk = (M_HULK in mutations) && !ishorrorform(src) && mind.special_role != HIGHLANDER // Part of the species.
+	var/skeleton = (M_SKELETON in mutations)
+
+	var/base_rgb = species.flesh_color
+	if(base_rgb == null)
+		base_rgb = rgb(255, 202, 149)
+	if(!skeleton && !husk && !hulk)
+		if(species.anatomy_flags & MULTICOLOR)
+			return AddRGB(base_rgb, rgb(multicolor_skin_r, multicolor_skin_g, multicolor_skin_b))
+		else if(species.anatomy_flags & RGBSKINTONE)
+			return AddRGB(base_rgb, rgb(my_appearance.r_hair, my_appearance.g_hair, my_appearance.b_hair))
+		else if(species.anatomy_flags & HAS_SKIN_TONE)
+			if(my_appearance.s_tone >= 0)
+				return AddRGB(base_rgb, rgb(my_appearance.s_tone, my_appearance.s_tone, my_appearance.s_tone))
+			else
+				return SubRGB(base_rgb, rgb(-my_appearance.s_tone, -my_appearance.s_tone, -my_appearance.s_tone))
+	return base_rgb
+
 //HAIR OVERLAY
 /mob/living/carbon/human/update_hair(update_icons = TRUE)
 	if(monkeyizing)

icons/effects/effects.dmi

@@ -260,6 +260,7 @@
 #include "code\datums\disease.dm"
 #include "code\datums\emotes.dm"
 #include "code\datums\feedback.dm"
+#include "code\datums\flash_animations.dm"
 #include "code\datums\fuzzy_rules.dm"
 #include "code\datums\gas_giant.dm"
 #include "code\datums\laser_tag_game.dm"