Back to the drawing board (#37538)

* Revert "May fix the login failure issue on 516 (#37537)"

This reverts commit 6071b0a.

* Revert "516 compatibility PR 2: the revenge of Node.js (#37501)"

This reverts commit 875eca8.

Author: ShiftyRail

.github/workflows/ci.yml

@@ -20,8 +20,8 @@ on:
   workflow_dispatch:
 
 env:
-  BYOND_MAJOR: 516
-  BYOND_MINOR: 1659
+  BYOND_MAJOR: 515
+  BYOND_MINOR: 1603
 
   #This can be declared here because build.py will ignore it if DM_UNIT_TESTS is true.
   ALL_MAPS: tgstation metaclub defficiency packedstation roidstation test_tiny test_vault snaxi tgstation-sec tgstation-snow LampreyStation xoq synergy bagelstation lowfatbagel Dorfstation waystation line horizon wheelstation

.vscode/tasks.json

@@ -89,15 +89,6 @@
 			],
 			"group": "build",
 			"label": "tgui: sonar"
-		},
-		{
-			"type": "npm",
-			"script": "install",
-			"path": "tgui",
-			"group": "clean",
-			"problemMatcher": [],
-			"label": "npm: install - tgui",
-			"detail": "install dependencies from package"
 		}
 	]
 }

__DEFINES/_macros.dm

@@ -439,4 +439,3 @@ var/global/list/visible_spaces = list(/turf/simulated/open, /turf/simulated/floo
 #define OMNI_LINK(A,B) isliving(A) && A:omnitool_connect(B)
 
 #define is_real_champion(A) ismob(A) && A.is_wearing_item(/obj/item/weapon/storage/belt/champion) && A.is_wearing_item(/obj/item/clothing/mask/luchador)
-

__DEFINES/cooldowns.dm

@@ -368,7 +368,7 @@ var/obj/abstract/screen/plane_master/overdark_planemaster/overdark_planemaster =
 	appearance_flags = 0
 	plane = BASE_PLANE
 	mouse_opacity = 0
-	screen_loc = "SOUTHWEST,SOUTHWEST"
+	screen_loc = "CENTER,CENTER"
 	render_source = "*overdark"
 
 var/obj/abstract/screen/plane_master/overdark_planemaster_target/overdark_planemaster_target = new()

__DEFINES/planes+layers.dm

@@ -6,6 +6,3 @@
 #define QDEL_LIST_ASSOC_NULL(L) QDEL_LIST_ASSOC(L); L = null
 #define QDEL_LIST_CUT(L) QDEL_LIST(L); L.Cut()
 #define QDEL_LIST_ASSOC_CUT(L) QDEL_LIST_ASSOC(L); L.Cut()
-
-// QDEL macros borrowed from TG
-#define QDELETED(X) (!X || X.gcDestroyed)

__DEFINES/qdel.dm

@@ -1,5 +1,5 @@
 //This file was auto-corrected by findeclaration.exe on 25.5.2012 20:42:31
-#if DM_VERSION < 516
+#if DM_VERSION < 513
 #error Your version of byond is too old, you need version 513 or higher
 #endif
 #define RUNWARNING // disable if they re-enable run() in 507 or newer.

__DEFINES/setup.dm

@@ -19,9 +19,6 @@
 /// Maximum ping timeout allowed to detect zombie windows
 #define TGUI_PING_TIMEOUT 4 SECONDS
 
-/// Used for rate-limiting to prevent DoS by excessively refreshing a TGUI window
-#define TGUI_REFRESH_FULL_UPDATE_COOLDOWN (1 SECONDS)
-
 /// Window does not exist
 #define TGUI_WINDOW_CLOSED 0
 /// Window was just opened, but is still not ready to be sent data
@@ -41,14 +38,3 @@
 #define TGUI_CREATE_MESSAGE(type, payload) ( \
 	"%7b%22type%22%3a%22[type]%22%2c%22payload%22%3a[url_encode(json_encode(payload))]%7d" \
 )
-
-// -- TG Style nameof() --
-#define PROC_REF(X) (nameof(.proc/##X))
-/**
- * NAMEOF: Compile time checked variable name to string conversion
- * evaluates to a string equal to "X", but compile errors if X isn't a var on datum.
- **/
-#define NAMEOF(datum, X) (#X || ##datum.##X)
-
-/// Call by name proc reference, checks if the proc exists on either the given type or as a global proc
-#define TYPE_PROC_REF(TYPE, X) (nameof(##TYPE.proc/##X))

__DEFINES/tgui.dm

@@ -14,7 +14,7 @@
 	var/internal_volume = 10000
 	var/max_pressure = 10000
 
-	var/target_pressure = 2500	//Output pressure.
+	var/target_pressure = 4500	//Output pressure.
 
 	var/datum/gas_mixture/air				//Internal tank.
 
@@ -102,19 +102,17 @@
 		))
 	return data
 
-/obj/machinery/atmospherics/binary/msgs/ui_act(action, list/params, datum/tgui/ui, datum/ui_state/state)
+/obj/machinery/atmospherics/binary/msgs/ui_act(action, list/params)
 	. = ..()
 	if(.)
 		return
 	switch(action)
 		if("toggle_power")
 			on = !on
 			update_icon()
-			SStgui.try_update_ui(ui.user, src, ui)
 			return TRUE
 		if("set_pressure")
 			target_pressure = round(clamp(text2num(params["new_pressure"]), 0, 4500))
-			SStgui.try_update_ui(ui.user, src, ui)
 			update_icon()
 			return TRUE
 

code/ATMOSPHERICS/components/binary_devices/MSGS.dm

@@ -29,9 +29,6 @@ var/cmp_field = "name"
 /proc/cmp_records_dsc(datum/data/record/a, datum/data/record/b)
 	return sorttext(a.fields[cmp_field], b.fields[cmp_field])
 
-/proc/cmp_records_numerically(datum/data/record/a, datum/data/record/b)
-	return b.fields[cmp_field] - a.fields[cmp_field]
-
 /proc/cmp_ckey_asc(client/a, client/b)
 	return sorttext(b.ckey, a.ckey)