adds to and fixes yet more fission things (#37460)

* sounds, bugfix

* +-1, bugfix

* randon rounding, ISC clarification

Author: CrazyAmphibian

code/controllers/subsystem/machinery.dm

@@ -37,6 +37,7 @@ var/list/global/fissionreactorlist=list()
 		reactor.fissioncycle()
 		reactor.coolantcycle()
 		reactor.misccycle()
+		reactor.emitsound()
 
 	var/obj/machinery/M
 	var/c = currentrun_index

code/game/objects/items/weapons/manuals.dm

@@ -1452,6 +1452,7 @@ building a reactor is an expensive endeavor, costing a lot of both time and reso
 	<h3>Isotopic Separational Combiner</h3>
 	<ol>
 		<li>Use 5 metal to construct a machine frame in the desired location</li>
+		<li><ul><li>Do note that the gas port will face SOUTH relative to your station's orientation</li></ul></li>
 		<li>Add 5 lengths of wiring to the machine</li>
 		<li>Insert the circuitboard</li>
 		<li>Add a 2 matter bins, micro-manipulator, 2 scanning modules, and a console screen to the frame</li>

code/modules/fissionreactor/fission_datums.dm

@@ -19,6 +19,8 @@ datums for the fission reactor, which includes the fuel and reactor
 	var/fuel_rods_affected_by_rods=0
 	var/time_last_ticked=null
 
+	var/time_last_sound_emission=0 //used to play sounds every 2 seconds.
+	
 	var/coolantport_counter=0 // this varible exists to ensure that all coolant ports get treated equally, because if we didn't it would have a flow prefrence towards the ports with lower indexes.
 	var/control_rod_insertion=1  //phase 1 vars. modified during runtime
 	var/control_rod_target=1 // this is to create a bit of input lag to make things a bit more tense. also allows autoscram to work while the controller is unpowered.
@@ -44,6 +46,7 @@ datums for the fission reactor, which includes the fuel and reactor
 	coolant.volume = CELL_VOLUME
 	fissionreactorlist+=src
 	time_last_ticked=world.time
+	time_last_sound_emission=world.time
 
 /datum/fission_reactor_holder/Destroy()
 	fissionreactorlist-=src //remove from global list
@@ -586,10 +589,35 @@ datums for the fission reactor, which includes the fuel and reactor
 	time_last_ticked=world.time
 
 
-
-
-
-
+/datum/fission_reactor_holder/proc/emitsound()
+	if(!considered_on())
+		return
+	if (world.time + 2 SECONDS >=time_last_sound_emission)
+		time_last_sound_emission=world.time
+		for(var/mob/living/M in world)
+			if(!M.client)
+				continue
+			if(M.loc.z!=zlevel)	
+				continue	
+			var/dx1=abs(M.loc.x-origin_x)
+			var/dx2=abs(M.loc.x-corner_x)
+			var/dy1=abs(M.loc.y-origin_y)
+			var/dy2=abs(M.loc.y-corner_y)
+			var/dist=max(min(dx1,dx2),min(dy1,dy2))
+			if( dist<11) //within 10 tiles of a reactor edge
+				var/sound/S = sound('sound/machines/fission/reactor_hum.ogg')
+				S.pan=0
+				if (M.loc.x>origin_x && M.loc.x > corner_x)
+					//pan right
+					S.pan=min(dx1,dx2)*-5
+				else if (M.loc.x<origin_x && M.loc.x < corner_x)
+					//pan left
+					S.pan=min(dx1,dx2)*5
+				
+				S.falloff = 2
+				S.volume=23*(1-control_rod_insertion)+10
+				M << S
+			
 
 
 /datum/fission_fuel

code/modules/fissionreactor/fuelmaker.dm

@@ -314,7 +314,9 @@ Container: [container ? container : "none"][container ? " \[[container.reagents.
 				html+="<td style='text-align:right;'><a  <a href='?src=\ref[interface];reagent=[R.id];dir=to_fuel;amount=1'>1u</a> <a href='?src=\ref[interface];reagent=[R.id];dir=to_fuel;amount=5'>5u</a> <a href='?src=\ref[interface];reagent=[R.id];dir=to_fuel;amount=10'>10u</a> <a href='?src=\ref[interface];reagent=[R.id];dir=to_fuel;amount=25'>25u</a> <a href='?src=\ref[interface];reagent=[R.id];dir=to_fuel;amount=999999'>All</a></td></tr>"
 		if(air_contents)
 			if(air_contents.gas[GAS_RADON])
-				html+="<tr><td> Radon <a href='?src=\ref[interface];reagent=RADON;dir=goto_wiki'>(?)</a> [air_contents.gas[GAS_RADON]] units </td>"
+				var/amt=air_contents.gas[GAS_RADON]
+				amt = amt < 0.01 ? "<0.01" : amt
+				html+="<tr><td> Radon <a href='?src=\ref[interface];reagent=radon;dir=goto_wiki'>(?)</a> [amt] units </td>"
 				html+="<td style='text-align:right;'><a  <a href='?src=\ref[interface];reagent=RADON;dir=to_fuel;amount=1'>1u</a> <a href='?src=\ref[interface];reagent=RADON;dir=to_fuel;amount=5'>5u</a> <a href='?src=\ref[interface];reagent=RADON;dir=to_fuel;amount=10'>10u</a> <a href='?src=\ref[interface];reagent=RADON;dir=to_fuel;amount=25'>25u</a> <a href='?src=\ref[interface];reagent=RADON;dir=to_fuel;amount=999999'>All</a></td></tr>"
 
 

code/modules/fissionreactor/objects_external.dm

@@ -156,6 +156,7 @@ included:
 	anchored =1
 	//circuit=/obj/item/weapon/circuitboard/fission_reactor
 	var/can_autoscram=TRUE //automatic safeties if it gets too hot or power is cut.
+	var/roddelta = 5 //% to move rods per click
 	var/datum/fission_reactor_holder/associated_reactor=null
 	var/obj/item/weapon/fuelrod/currentfuelrod=null
 	var/poweroutagemsg=FALSE
@@ -425,7 +426,12 @@ included:
 
 <div style='display:inline-block;width:100%;'>
 <a href='?src=\ref[interface];action=eject' [(!associated_reactor.fuel ||  associated_reactor.considered_on()) ? "class='blocked'" : ""]>\[EJECT FUEL\]</a>&nbsp;&nbsp;<a href='?src=\ref[interface];action=swap_tempunit'>\[TEMPERATURE\]</a>&nbsp;&nbsp;&nbsp;<a href='?src=\ref[interface];action=rods_up'>\[RODS UP\]</a> <br>
-&nbsp;<a href='?src=\ref[interface];action=SCRAM' id='scram' style='[associated_reactor.SCRAM ? "animation-name:scramon;" : "" ]'>\[&nbsp;SCRAM&nbsp;]</a>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<a href='?src=\ref[interface];action=swap_gasunit'>\[COOLANT\]</a>&nbsp;&nbsp;&nbsp;&nbsp;<a href='?src=\ref[interface];action=rods_down'>\[RODS DOWN\]</a>
+&nbsp;<a href='?src=\ref[interface];action=SCRAM' id='scram' style='[associated_reactor.SCRAM ? "animation-name:scramon;" : "" ]'>\[&nbsp;SCRAM&nbsp;]</a>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<a href='?src=\ref[interface];action=swap_gasunit'>\[COOLANT\]</a>&nbsp;&nbsp;&nbsp;&nbsp;<a href='?src=\ref[interface];action=rods_down'>\[RODS DOWN\]</a> <br>
+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<a href='?src=\ref[interface];action=setdelta_5' [roddelta==5 ? "class='blocked'" : ""]>\[RODS +- 5\]</a>&nbsp;&nbsp;&nbsp;<a href='?src=\ref[interface];action=setdelta_1' [roddelta==1 ? "class='blocked'" : ""]>\[RODS +- 1\]</a>
+
+
+
+
 </div>
 
 </div>
@@ -636,18 +642,16 @@ included:
 			to_chat(usr, "<span class='warning'>WARNING: Connection failure. Reduce range.</span>")
 			return 1
 
-	
-	
 	switch(href_list["action"])
 		if("SCRAM")
 			if(!associated_reactor.SCRAM)
 				playsound(src,'sound/machines/fission/rc_scram.ogg',50)
 			associated_reactor.SCRAM=TRUE
 		if("rods_up")
-			associated_reactor.control_rod_target-=0.05
+			associated_reactor.control_rod_target-=roddelta/100
 			associated_reactor.control_rod_target=max(0,associated_reactor.control_rod_target)
 		if("rods_down")
-			associated_reactor.control_rod_target+=0.05
+			associated_reactor.control_rod_target+=roddelta/100
 			associated_reactor.control_rod_target=min(1,associated_reactor.control_rod_target)
 		if("eject")
 			if(!associated_reactor.fuel)
@@ -664,6 +668,10 @@ included:
 			tempdisplaymode%=4
 		if("swap_gasunit")		
 			displaycoolantinmoles=!displaycoolantinmoles
+		if("setdelta_5")
+			roddelta=5
+		if("setdelta_1")
+			roddelta=1
 
 	ask_remakeUI() //update it so that changes appear NOW.
 //SS_WAIT_MACHINERY
@@ -864,7 +872,7 @@ included:
 					if(state!=0)
 						return
 					user.visible_message("<span class='warning'>[user] dissasembles \the [src].</span>", "<span class='notice'>You dissasemble \the [src].</span>")
-					new material(get_turf(src), 4)
+					new material(get_turf(src), 3)
 					qdel(src)
 				return
 			to_chat(user, "<span class='notice'>You can't find a use for \the [W]</span>")

code/modules/research/designs/boards/computer_engie.dm

@@ -197,7 +197,7 @@
 
 /datum/design/fission_fuel_maker
 	name = "Circuit Design (Isotopic Separational Combiner)"
-	desc = "Allows for the construction of circuit boards used to seperate and combine different isotopes of materials"
+	desc = "Allows for the construction of circuit boards used to separate and combine different isotopes of materials.\nRemember that the gas port will face south once constructed."
 	id = "fission_control"
 	req_tech = list(Tc_PROGRAMMING = 4, Tc_ENGINEERING = 4)
 	build_type = IMPRINTER