Vendor coinbox and vendpack qol (#36668)

* Vendor coinbox and vendpack qol

* removes this error from happening

* unatomic, will do in other pr

* hotfix for this

* makes coinbox buildable, this version has no access requirements

Author: SECBATON-GRIFFON

code/game/machinery/constructable_frame.dm

@@ -1170,7 +1170,8 @@ to destroy them and players will be able to make replacements.
 	req_components = list(
 							/obj/item/weapon/stock_parts/matter_bin = 1,
 							/obj/item/weapon/stock_parts/manipulator = 1,
-							/obj/item/weapon/stock_parts/scanning_module = 1)
+							/obj/item/weapon/stock_parts/scanning_module = 1,
+							/obj/item/weapon/storage/lockbox/coinbox = 1)
 
 /obj/item/weapon/circuitboard/pdapainter
 	name = "Circuit Board (PDA Painter)"

code/game/machinery/vending.dm

@@ -141,7 +141,8 @@ var/global/num_vending_terminals = 1
 		/obj/item/weapon/circuitboard/vendomat,\
 		/obj/item/weapon/stock_parts/matter_bin,\
 		/obj/item/weapon/stock_parts/manipulator,\
-		/obj/item/weapon/stock_parts/scanning_module\
+		/obj/item/weapon/stock_parts/scanning_module,\
+		/obj/item/weapon/storage/lockbox/coinbox\
 	)
 
 	RefreshParts()
@@ -155,8 +156,6 @@ var/global/num_vending_terminals = 1
 
 		power_change()
 
-	coinbox = new(src)
-
 	for(var/langname in slogan_languages)
 		if(istext(langname))
 			slogan_languages -= langname
@@ -190,6 +189,10 @@ var/global/num_vending_terminals = 1
 		if(istype(SP, /obj/item/weapon/stock_parts/manipulator))
 			manipcount += SP.rating
 	shoot_chance = manipcount * 3
+	
+	coinbox = locate() in component_parts
+	if(!coinbox)
+		coinbox = new(src)
 
 /obj/machinery/vending/Destroy()
 	if(wires)
@@ -201,15 +204,18 @@ var/global/num_vending_terminals = 1
 /obj/machinery/vending/splashable()
 	return FALSE
 
+/obj/machinery/vending/spillContents(destroy_chance)
+	. = ..()
+	dump_vendpack_and_coinbox()
+
 /obj/machinery/vending/proc/dump_vendpack_and_coinbox()
 	if(product_records.len && cardboard) //Only spit out if we have slotted cardboard
+		var/obj/structure/vendomatpack/custom/newpack = new(src.loc)
 		if(is_custom_machine)
-			var/obj/structure/vendomatpack/custom/newpack = new(src.loc)
 			for(var/obj/item/I in custom_stock)
 				I.forceMove(newpack)
 				custom_stock.Remove(I)
 		else
-			var/obj/structure/vendomatpack/partial/newpack = new(src.loc)
 			newpack.stock = products
 			newpack.secretstock = contraband
 			newpack.preciousstock = premium
@@ -220,7 +226,8 @@ var/global/num_vending_terminals = 1
 			newpack.targetvendomat = src.type
 
 	if(coinbox)
-		coinbox.forceMove(get_turf(src))
+		coinbox.forceMove(src.loc)
+		coinbox = null
 
 /obj/machinery/vending/examine(var/mob/user)
 	..()
@@ -286,7 +293,6 @@ var/global/num_vending_terminals = 1
 				if(user.machine==src)
 					newmachine.attack_hand(user)
 				component_parts = 0
-				qdel(coinbox)
 				qdel(src)
 			else
 				is_being_filled = FALSE

code/game/objects/items/stacks/stack_recipes.dm

@@ -411,6 +411,7 @@ var/list/datum/stack_recipe/metal_recipes = list (
 	new/datum/stack_recipe("cannonball", /obj/item/cannonball/iron, 20, time = 4 SECONDS, one_per_turf = 0, on_floor = 1),
 	new/datum/stack_recipe("frying pan", /obj/item/weapon/reagent_containers/pan, 10, time = 4 SECONDS, one_per_turf = 0, on_floor = 0),
 	new/datum/stack_recipe("lunch box", /obj/item/weapon/storage/lunchbox/metal, 1, time = 2 SECONDS, one_per_turf = 0, on_floor = 0),
+	new/datum/stack_recipe("coinbox", /obj/item/weapon/storage/lockbox/coinbox/allaccess, 1, time = 2 SECONDS, one_per_turf = 0, on_floor = 0),
 	null,
 	blacksmithing_recipes,
 	null,

code/game/objects/items/weapons/storage/lockbox.dm

@@ -275,12 +275,15 @@
 	throwforce = 10
 	storage_slots = 20
 	req_one_access = list(access_qm)
-	locked = 1
-	broken = 0
+	starting_materials = list(MAT_IRON = CC_PER_SHEET_METAL)
+	w_type = RECYK_ELECTRONIC
 	icon_locked = "coinbox+l"
 	icon_closed = "coinbox"
 	icon_broken = "coinbox+b"
 
+/obj/item/weapon/storage/lockbox/coinbox/allaccess	
+	req_one_access = null
+
 /obj/item/weapon/storage/lockbox/lawgiver
 	name = "lockbox (lawgiver)"
 	req_one_access = list(access_armory)