Makes the unit test pass

Author: ShiftyRail

code/controllers/subsystem/init/persistence_misc.dm

@@ -226,25 +226,50 @@ var/datum/subsystem/persistence_misc/SSpersistence_misc
 	name = "Money highscores"
 	file_path = "data/persistence/money_highscores.json"
 
+// Translated a list of /record/money into a list of data
+/datum/persistence_task/highscores/proc/listify()
+	var/list/L = list()
+	for(var/datum/record/money/record in data)
+		L += list(
+			"ckey" = record.ckey,
+			"role" = record.role,
+			"cash" = record.cash,
+			"shift_duration" = record.shift_duration,
+			"date" = record.date,
+		)
+	return L
+
+// Translated a list of data into a list of /record/money
+/datum/persistence_task/highscores/proc/datumify(var/list/to_read)
+	var/list/processed_data = list()
+	for(var/list/L in to_read)
+		var/datum/record/money/record = new(L["ckey"], L["role"], L["cash"], L["shift_duration"], L["date"])
+		processed_data += record
+	return processed_data
+
 /datum/persistence_task/highscores/on_init()
 	var/to_read = read_file()
 	if(!to_read)
 		log_debug("[name] task found an empty file on [file_path]")
 		return
-	for(var/list/L in to_read)
-		var/datum/record/money/record = new(L["ckey"], L["role"], L["cash"], L["shift_duration"], L["date"])
-		data += record
+
+	data = datumify(to_read)
 
 /datum/persistence_task/highscores/on_shutdown()
-	var/list/L = list()
-	for(var/datum/record/money/record in data)
-		L += list(record.vars)
+	var/list/L = listify(data)
 	write_file(L)
 
 /datum/persistence_task/highscores/proc/insert_records(list/records)
 	data += records
+
+	// Need to listify it to access the "cash" value with sortTrim
+	var/list/data_as_list = listify(data)
+	world.log << "list#1 before: [data_as_list[1]["name"]]"
 	global.cmp_field = "cash"
-	sortTim(data, /proc/cmp_list_by_element_desc)
+	sortTim(data_as_list, /proc/cmp_list_by_element_desc)
+	world.log << "list#1 after: [data_as_list[1]["name"]]"
+	data = datumify(data_as_list)
+
 	if (data.len > 5)
 		data.Cut(6) // we only store the top 5
 	for(var/datum/record/money/record in data)