Skip to content

Conversation

west3436
Copy link
Collaborator

@west3436 west3436 commented Jul 29, 2024

What this does

Adds Silencing Spray which can be used on anything Invisibility Spray works on and will prevent it from making any sounds for 5 minutes (regular) or permanently (clown/mime traitor item only). Also refactored invisibility spray so it shares the same parent as silencing spray.

Why it's good

Sounds fun and closes #25861.

How it was tested

  • Spawned a mime and assigned a traitor role.
  • Tested the invisibility spray to ensure proper behavior was maintained after the refactor.
  • Tested spraying the silencing spray on various sound-emitting movable atoms.

Changelog

🆑

  • rscadd: Added Silencing Spray which can be used to silence any mob/obj/machine which it's sprayed on.

@west3436 west3436 added Content Adds something. Neat! WiP I'm not completely done yet! 0% tested What could possibly go wrong / Try again after testing it. labels Jul 29, 2024
@west3436 west3436 changed the title Silentspray Silencing Spray Jul 29, 2024
@wotisjanitor
Copy link
Contributor

What are some interesting uses for this?

@wotisjanitor
Copy link
Contributor

Also it would be funny if it had a special interaction with mimes

@west3436
Copy link
Collaborator Author

What are some interesting uses for this?

Loud items like guns, eswords, the organ extractor, etc can by used more stealthily now. Combining this with invisibility spray could make the shard super evil, though I haven't tested it yet.

@ErrorsWindows
Copy link
Contributor

okay
but how well does this silencing spray work on

P̴̜̼̹̫͚͎͙̠̝̖̫͉̲͓͖̞̅̍̀̌̏̊͊̐͊̍̓̊̎̋͐́͘ͅ ̶̧͙̞̼̬̀̋͋̔̈̓̿̕Ȩ̴̢̭͔͖̗͇͒͜ͅ ̷͙͙̘̦̉̈́͋͑̇̐̑́̚͠ Ọ̵̣͔͓̼͎͂̿̓̓̿́͒͜͝ ̵͙͚̭͔̼̦̮̹̻̓̑̚͜P̷̨̡̧̧̙̪̤̲̳̮͖̰̣͕̱̞͂̎ ̶̢̝̭͍͔̥̟̳͓̗̊͋̃̈́̈́̄̚͜͝͝Ļ̸̢̨̛̳̻̞͈̣̫͕̲̥͕͊̿̋͂̐̔̊ ̶̢͕̯͈̘̻̠̘̦̗̣͇̖̊̋̓̔̃̒͝Ẽ̶͓̮̓̏̈́́̔̉̔̄͊̚͘̚͠

@angryturnip
Copy link
Contributor

I can't wait to spray the juke and antagonize the active admin for the round when he gets a bunch of ahelps about it not working

@angryturnip
Copy link
Contributor

By the way, does this make bomb explosions silent or is the explosion sound separate from the object?

@west3436
Copy link
Collaborator Author

By the way, does this make bomb explosions silent or is the explosion sound separate from the object?

My man this is 0% tested lmao but I'd assume this would silence the bomb.

@west3436 west3436 marked this pull request as ready for review August 14, 2024 13:50
@west3436 west3436 removed 0% tested What could possibly go wrong / Try again after testing it. WiP I'm not completely done yet! labels Aug 14, 2024
@wotisjanitor
Copy link
Contributor

You removed the untested label, how did you test it?

@west3436
Copy link
Collaborator Author

You removed the untested label, how did you test it?

I literally updated the OP with details on how I tested it lol

@jwhitak jwhitak merged commit fcaa424 into vgstation-coders:Bleeding-Edge Aug 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Adds something. Neat!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Silence spray
5 participants