-
Notifications
You must be signed in to change notification settings - Fork 548
Insulted gloves that call you names and insult you when you get shocked. #36963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
code/modules/power/powernet.dm
Outdated
if(H.gloves) | ||
var/obj/item/clothing/gloves/G = H.gloves | ||
|
||
if(G.name == "insulted gloves") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type check here would be better, even with the == since its less intensive but up to you to use that instead of istype()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This type of check isn't too bad because strings are all stored as references on the string table... That said, this prevents renaming gloves for meme purposes. And hand labelers will silence the gloves for good.
This whole setup could be added as a general variable, such as var/insults_on_shock, to obj/item/clothing/gloves for adminbus purposes. Then you can simply check the variable here. Benefits? Admins get a new button to mess with players. Drawbacks? New meme variable on all gloves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
speaking of meme variables, why does every fucking atom have a list of armor and a bunch of other stuff they never use?
if i recall right lummox said something about how retarded that is once
meme content |
code/modules/power/powernet.dm
Outdated
if(H.gloves) | ||
var/obj/item/clothing/gloves/G = H.gloves | ||
|
||
if(G.name == "insulted gloves") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This type of check isn't too bad because strings are all stored as references on the string table... That said, this prevents renaming gloves for meme purposes. And hand labelers will silence the gloves for good.
This whole setup could be added as a general variable, such as var/insults_on_shock, to obj/item/clothing/gloves for adminbus purposes. Then you can simply check the variable here. Benefits? Admins get a new button to mess with players. Drawbacks? New meme variable on all gloves.
@Eneocho address feedback then I'll merge |
code/modules/power/powernet.dm
Outdated
if(G.siemens_coefficient == 0) // to avoid spamming with insulated glvoes on | ||
return 0 | ||
|
||
if(G.name == "insulted gloves") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My brother in christ, please just do a typecheck here instead of checking for the gloves' name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i do a name check cause otherwise the budget insulos turned insulted (april fools) don't insult you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, just transform the budget insuls into insulted gloves when equipped during April Fools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wanted them to spawn transformed into the insulted ones instead (and I don't feel like remapping), that was the simplest option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case just add an April fools check in the budget gloves New() proc which spawns insulted gloves and qdels the budget gloves
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guess that works, lemme see what I can do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did the thing
What this does
Adds Insulted Gloves on the autodrobe, these gloves will call you names and mock you if you get shocked.
Budget insulated gloves will be replaced with insulted gloves instead on april fools.
Why it's good
Funny
How it was tested
Wore gloves, snipped a wire, got called an idiot by my own gloves.
🆑