Skip to content

Conversation

Eneocho
Copy link
Collaborator

@Eneocho Eneocho commented Aug 20, 2024

What this does

Adds Insulted Gloves on the autodrobe, these gloves will call you names and mock you if you get shocked.
Budget insulated gloves will be replaced with insulted gloves instead on april fools.

Why it's good

Funny

How it was tested

Wore gloves, snipped a wire, got called an idiot by my own gloves.
🆑

  • rscadd: Clowns can buy Insulted gloves from the autodrobe, these may also be found where budget insulos would be laying around on april fools. Don't cut wires while wearing them, or you will get insulted when you get shocked.

@Eneocho Eneocho added Honk Honk Content Adds something. Neat! labels Aug 20, 2024
if(H.gloves)
var/obj/item/clothing/gloves/G = H.gloves

if(G.name == "insulted gloves")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type check here would be better, even with the == since its less intensive but up to you to use that instead of istype()

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type of check isn't too bad because strings are all stored as references on the string table... That said, this prevents renaming gloves for meme purposes. And hand labelers will silence the gloves for good.

This whole setup could be added as a general variable, such as var/insults_on_shock, to obj/item/clothing/gloves for adminbus purposes. Then you can simply check the variable here. Benefits? Admins get a new button to mess with players. Drawbacks? New meme variable on all gloves.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

speaking of meme variables, why does every fucking atom have a list of armor and a bunch of other stuff they never use?
if i recall right lummox said something about how retarded that is once

@SonixApache
Copy link
Contributor

meme content

if(H.gloves)
var/obj/item/clothing/gloves/G = H.gloves

if(G.name == "insulted gloves")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type of check isn't too bad because strings are all stored as references on the string table... That said, this prevents renaming gloves for meme purposes. And hand labelers will silence the gloves for good.

This whole setup could be added as a general variable, such as var/insults_on_shock, to obj/item/clothing/gloves for adminbus purposes. Then you can simply check the variable here. Benefits? Admins get a new button to mess with players. Drawbacks? New meme variable on all gloves.

@west3436
Copy link
Collaborator

@Eneocho address feedback then I'll merge

if(G.siemens_coefficient == 0) // to avoid spamming with insulated glvoes on
return 0

if(G.name == "insulted gloves")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My brother in christ, please just do a typecheck here instead of checking for the gloves' name.

Copy link
Collaborator Author

@Eneocho Eneocho Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do a name check cause otherwise the budget insulos turned insulted (april fools) don't insult you

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, just transform the budget insuls into insulted gloves when equipped during April Fools.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wanted them to spawn transformed into the insulted ones instead (and I don't feel like remapping), that was the simplest option

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case just add an April fools check in the budget gloves New() proc which spawns insulted gloves and qdels the budget gloves

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess that works, lemme see what I can do

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did the thing

@Eneocho Eneocho requested a review from west3436 September 6, 2024 14:25
@west3436 west3436 merged commit d82b66e into vgstation-coders:Bleeding-Edge Sep 7, 2024
5 checks passed
@Eneocho Eneocho deleted the patch-22 branch September 7, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Adds something. Neat! Honk Honk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants