Adds Missing Shuttlecrush Edit to Shuttle Magic #36981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhitak
added
Bug / Fix
west3436
reviewed
Aug 26, 2024
Comment on lines
+4996
to
+5001
| if(new_value == "CRUSH") | ||
| S.destroy_everything = TRUE | ||
| else if(new_value == "No crush") | ||
| S.destroy_everything = FALSE | ||
| else | ||
| return |
There was a problem hiding this comment.
Suggested change
| if(new_value == "CRUSH") | |
| S.destroy_everything = TRUE | |
| else if(new_value == "No crush") | |
| S.destroy_everything = FALSE | |
| else | |
| return | |
| S.destroy_everything = new_value == "CRUSH" ? TRUE : FALSE |
There was a problem hiding this comment.
There's the if(new_value == null) case, where you just cancel out the input (no change), represented in the final else case above. I could implement your changes but I'd want to add in a quick if(isnull(new_value)) return above it.
west3436
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nobody told the coders...
What this does
Fixes the dead option in the Shuttle Magic panel to toggle the destroy_everything variable. Most admins with vv used things like vv to directly edit the variable, but admins without this ability desired the option to edit this value.
Why it's good
silent can shuttlecrush people
How it was tested
Opened the panel, tried the options out on various shuttles, canceling, verifying the variable was changed, etc.
