Skip to content

Adds Missing Shuttlecrush Edit to Shuttle Magic #36981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Adds Missing Shuttlecrush Edit to Shuttle Magic #36981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions code/modules/admin/topic.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4991,6 +4991,14 @@ access_sec_doors,access_salvage_captain,access_cent_ert,access_syndicate,access_
if("can rotate")
new_value = input(usr,"0 - rotation disabled, 1 - rotation enabled","Shuttle editing",S.can_rotate) as num
S.can_rotate = new_value
if("destroy areas")
new_value = input(usr,"Allow this shuttle to crush into areas? Currently set to: [S.destroy_everything ? "True" : "False"]","Shuttle editing") as null|anything in list("CRUSH","No crush")
if(new_value == "CRUSH")
S.destroy_everything = TRUE
else if(new_value == "No crush")
S.destroy_everything = FALSE
else
return
Comment on lines +4996 to +5001
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(new_value == "CRUSH")
S.destroy_everything = TRUE
else if(new_value == "No crush")
S.destroy_everything = FALSE
else
return
S.destroy_everything = new_value == "CRUSH" ? TRUE : FALSE

Copy link
Collaborator Author

@jwhitak jwhitak Aug 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's the if(new_value == null) case, where you just cancel out the input (no change), represented in the final else case above. I could implement your changes but I'd want to add in a quick if(isnull(new_value)) return above it.

if("DEFINED LOCATIONS")
to_chat(usr, "To prevent accidental mistakes, you can only set these locations to docking ports in the shuttle's memory (use the \"Add a destination docking port to a shuttle\" command)")

Expand Down