Thermostat Fixes

[jwhitak]

They were broken?

yes. yes they were.

What this does

Fixes thermostats so that their controls actually do something now besides make an indefinite clicking noise. The following are a list of the changes:

• Thermostat controls actually set the temperature now, properly setting and using the correct variable.
  
  (@brndd's one mistake, uncaught for 5 years)

• Correctly shows the maximum amounts in C instead of K.
  

• Rounds off odd decimal inputs.
  Before:
  
  After:
  

• Allows inputing the exact minimum and maximum, such as the default 0 and 40C.
  Before:
  
  After:
  This doesn't happen.

• Allows inputting 0C as a valid input.

• BONUS: If you try to input a number outside of the range, it'll be clamped to the range. E.g. if you try to drop 99999 in a default thermostat, it'll treat it as 40.

• Thermostats will now announce if they switch between heating and cooling modes.
  

Why it's good

I want it warm in my leather making hotroom (thermostats set to 40C, the default maximum, can't get the room warm enough to cure leather quickly...), and I want it cold in the kitchen backroom, like it should be.

How it was tested

The usual - opening up ye olde test server and playing around with all the changes. Heating and cooling arbitarily, trying to set it to 0C to freeze to death, then changing the threshold presets to let me really up the thermostat and cure leather.
Before:

After:

Changelog

🆑

• bugfix: Thermostats now properly work when setting new temperatures.

[SECBATON-GRIFFON]

who touched the thermostat

[toomykins]

amazingly good fix.
hope this also miraculously fixes #35711

[west3436]

What is the default control range (max-min) for these? Should be wide enough to prevent constant triggering.

[jwhitak]

The control range is that the air alarm's heating/cooling will turn on if it exceeds 2C of the desired temperature, and turn off if it's within 0.5C of the desired temperature. The amount heated/cooled scales based on the difference in desired/actual temperature, and the heat capacity of the gas sample taken.