Psychedelic Jumpsuit (and the Clown equivalents) now glow in the dark #37025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
was expecting a mild tile glow too, but this is fine |
|
I thought psychedelic jumpsuits simply switched colors between jumpsuits, not actually glow too |
|
It's not about whether they do. It's about whether they should. |
|
horrific |
DeityLink
force-pushed
the
20240901-PsycheGlow
branch
from
879cbf5 to
cfd65dc
Compare
west3436
approved these changes
Sep 3, 2024
| var/image/dyn_overlay_left | ||
| var/image/dyn_overlay_right | ||
|
|
||
| if ((luminosity > 0) || (dyed_parts.len > 0)) |
There was a problem hiding this comment.
Nit, but relational operators always are checked prior to boolean operators so your parentheses are not necessary.
There was a problem hiding this comment.
double nit, dyed_parts.len > 0 could be simplified to dyed_parts.len
D3athrow-Issues
added a commit
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024-09-01.18-20-12.mp4
🆑