Skip to content

Conversation

SECBATON-GRIFFON
Copy link
Contributor

@SECBATON-GRIFFON SECBATON-GRIFFON commented Oct 2, 2024

[content]

What this does

the do_after bars now show up for anyone the action is being applied to

Why it's good

gives them a visual reference of how long it takes someone to forcefeed you or etc

How it was tested

calling attackby on the other mob with the player as an argument with things like cuffs and food
calling strip_item_from() on the players worn jumpsuit and the other mob, with pickpocketing on and off

Changelog

🆑

  • rscadd: Progress bars from actions are now visible to the targets of these actions, if enabled in prefs and not via pickpocketing or vampire silent bites.

@D3athrow-Issues D3athrow-Issues added the Bug / Fix This is either a bug or a fix for a bug. label Oct 2, 2024
@SECBATON-GRIFFON
Copy link
Contributor Author

i gave it the wrong label pls fix

@SonixApache
Copy link
Contributor

might be smart to allow overrides to hide for case-by-case specifics

@SECBATON-GRIFFON
Copy link
Contributor Author

might be smart to allow overrides to hide for case-by-case specifics

which ones in mind?

@SonixApache
Copy link
Contributor

nothing comes up but i foresee consequences for stealthy things
like trying to steal things with the thief gloves for example

@SECBATON-GRIFFON
Copy link
Contributor Author

nothing comes up but i foresee consequences for stealthy things like trying to steal things with the thief gloves for example

good point, i'll see what i can cover

@angryturnip
Copy link
Contributor

On the fence about this because stuff like stealth cuffing someone and hoping they are just looking at the game instead of the text at the side is a staple tactic. It would be nice if maybe like on harm intent the bar doesn't show up for others still or something like that to still have the option.

@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review October 3, 2024 15:45
@west3436 west3436 merged commit 38d1837 into vgstation-coders:Bleeding-Edge Oct 8, 2024
5 checks passed
@SECBATON-GRIFFON SECBATON-GRIFFON deleted the target-progress-bar branch October 8, 2024 16:05
west3436 added a commit that referenced this pull request Oct 9, 2024
west3436 added a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug / Fix This is either a bug or a fix for a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants