Spacesuit Modificiation Station Fixes #37258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhitak
added
Bug / Fix
west3436
approved these changes
Oct 12, 2024
D3athrow-Issues
added a commit
that referenced
this pull request
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This fixes a bug where the suit modification station would never work for plasmamen or vox. I swear I tested it! I think what happened was I added the activated=true line after testing in order to prevent a possible bug........... yeah oops caused a new bug.
This also fixes a bug that allows a plasma man or vox to take off their suit while it's being modified. Watching the suit get qdel'd from across the room was funny but yeah, nah.
Finally, this cleans up some phrasing and timing of the verbal reporting that the machine does. E.g. it now says it's installing the module as it's installing it instead of after the installation is finished.
Why it's good
Vox who steal the spare and want to think of themselves as Captain will now rush to this working suit modification station, only to discover what the vox captain suit actually looks like...
How it was tested
After all the code was done(!!!), I got on as a vox and plasmaman, grabbed the captain ID, and played around with swapping. Then I snagged a human body and tested module/cell inserting/removing and rigsuit installing/uninstalling of aforementioned modules/cells.
Changelog
🆑