Skip to content

Conversation

SECBATON-GRIFFON
Copy link
Contributor

@SECBATON-GRIFFON SECBATON-GRIFFON commented Oct 11, 2024

[bugfix][consistency]

What this does

Closes #37255.
also cleans up this file by removing redundant variable declarations from supertypes.

How it was tested

spawn plastic crate, drags into and out of disposals bin.

Changelog

🆑

  • bugfix: Plastic crates now actually behave like crates in many ways, such as not letting stood up mobs inside, going into disposals bins, shuffling the contents inside, and etc.

@D3athrow-Issues D3athrow-Issues added Bug / Fix This is either a bug or a fix for a bug. Consistency Issue This thing in question isn't consistent across multiple things. labels Oct 11, 2024
@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review October 11, 2024 17:19
@west3436
Copy link
Collaborator

Pretty sure every map has a plastic crate mapped in the cargo bay. Did you confirm every instance of the old typepath has been replaced?

@SECBATON-GRIFFON
Copy link
Contributor Author

Pretty sure every map has a plastic crate mapped in the cargo bay. Did you confirm every instance of the old typepath has been replaced?

yep, searched "pcrate" and found absolutely nothing. that's the food crates you're thinking of. only meta had them mapped anywhere.

@west3436 west3436 merged commit f0bd028 into vgstation-coders:Bleeding-Edge Oct 14, 2024
5 checks passed
@SECBATON-GRIFFON SECBATON-GRIFFON deleted the plastic-crate-fix branch October 14, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug / Fix This is either a bug or a fix for a bug. Consistency Issue This thing in question isn't consistent across multiple things.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plastic crates can't be dragged into disposal bins
3 participants