Skip to content

Conversation

SECBATON-GRIFFON
Copy link
Contributor

@SECBATON-GRIFFON SECBATON-GRIFFON commented Nov 4, 2024

[consistency][hotfix]

What this does

redo of #33617 but without refactoring entire systems

Why it's good

see changelog

How it was tested

using the relevant tools

Changelog

🆑

  • rscadd: Mortars can now grind anything an all-in-one grinder can, to the same amounts, and vice versa.

@D3athrow-Issues D3athrow-Issues added Consistency Issue This thing in question isn't consistent across multiple things. Hotfix This is a quick fix to something. labels Nov 4, 2024
@SECBATON-GRIFFON SECBATON-GRIFFON changed the title Grind list consistency Standardizes item blending, no refactor Nov 4, 2024
@west3436 west3436 closed this Feb 18, 2025
@Kurfursten
Copy link
Collaborator

@west3436 The code here looks fine. The OP incorrectly references the PR this replicates, which should be #36617

The original PR was reverted because there were oversights in the refactor that ultimately caused many important things (e.g.: wheat) to not grind at all. However, nothing added here should cause problems.

This system in general should be refactored, although it's unlikely it will ever happen due to the age of the repo.

@west3436 west3436 reopened this Mar 3, 2025
@west3436 west3436 merged commit b61c5fb into vgstation-coders:Bleeding-Edge Mar 3, 2025
8 checks passed
@SECBATON-GRIFFON SECBATON-GRIFFON deleted the grind-list-consistency branch March 4, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Consistency Issue This thing in question isn't consistent across multiple things. Hotfix This is a quick fix to something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants