Skip to content

Conversation

CrazyAmphibian
Copy link
Contributor

@CrazyAmphibian CrazyAmphibian commented Feb 21, 2025

[bugfix]
oops.

addresses some things in #37439

Changelog

🆑

  • tweak: the reactor expansion-pak now only gives 1 control rod circuit board (instead of 2) to reduce clutter.
  • tweak: reactor now irradiate over a larger area.
  • tweak: reactor casings take less time to build
  • tweak: reactor casings with piping now visually show their direction
  • bugfix: fixed the ISC not being able to be deconstructed
  • bugfix: fixed reactor girders not giving the correct number of plasteel sheets when deconstructing
  • bugfix: fixed piping from reactors not returning the correct pipe
  • imageadd: fuel rods will now animate when a reactor is on
  • spellcheck: fission reactor coolant ports no longer face ''soth''
  • spellcheck: the NantoTrasen engineering team has revised the reactor guidebook to address a few lingering questions about the design of reactors.

@D3athrow-Issues D3athrow-Issues added the Bug / Fix This is either a bug or a fix for a bug. label Feb 21, 2025
@Eneocho
Copy link
Collaborator

Eneocho commented Feb 21, 2025

the reactor expansion-pak now only gives 1 control rod circuit board (instead of 2) to reduce clutter.

make it 1:3 instead of 1:2

@CrazyAmphibian
Copy link
Contributor Author

but there's only supplies for 2 parts

@Eneocho
Copy link
Collaborator

Eneocho commented Feb 21, 2025

but there's only supplies for 2 parts

add a enough for a third one :)

@Eneocho
Copy link
Collaborator

Eneocho commented Feb 21, 2025

also, the dmi file I sent you has 3 variants for the light pulse timing, are you gonna use the variants?

@CrazyAmphibian
Copy link
Contributor Author

i don't really know how i would use the other variants

@Eneocho
Copy link
Collaborator

Eneocho commented Feb 21, 2025

I'd just have them swap around randomly.

reactor/new()
       icon_state = fuelrod_active[pick(1,3)]

and

reactor/process()
       if(prob(5))
              icon_state = fuelrod_active[pick(1,3)]

Copy link
Collaborator

@west3436 west3436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the warning lints as well - those will result in runtimes if not addressed.

Copy link
Collaborator

@west3436 west3436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar only

CrazyAmphibian and others added 2 commits February 23, 2025 20:19
Co-authored-by: west3436 <66280799+west3436@users.noreply.github.com>
Co-authored-by: west3436 <66280799+west3436@users.noreply.github.com>
@west3436 west3436 merged commit c5787f4 into vgstation-coders:Bleeding-Edge Feb 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug / Fix This is either a bug or a fix for a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants