A port of an early version of Baystation's new instruments

[mentgah]

What this does

I ported an early version of Baystation's new instruments, for now there's only one new physical instruments (the synth) which contains all of them. Future PRs will add more physical instruments (for now, old instruments are still there in the code and still work). The new interface looks like this.

New features include:

1. A sustain function which might be the most requested feature ever;
2. Several new instruments: Several brass instruments, chromatic percussions, fun ones like HONK, guitars, tones (square, sine and sawtooth waves), organs and pianos.
3. A "virtual environment" function (still not in use) which allows you to change these parameters: "Direct", "Direct (High Frequency)","Room","Room (High Frequency)","Obstruction","Obstruction (Low Frequency Ratio)","Occlusion","Occlusion (Low Frequency Ratio)","Occlusion (Room Ratio)","Occlusion (Direct Ratio)","Exclusion","Exclusion (Low Frequency Ratio)","Outside Volume (High Frequency)","Doppler Factor","Rolloff Factor","Room Rolloff Factor","Air Absorption Factor","Flags" for more immersive music playing

Why it's good

Because our instruments sound bad and work bad.

How it was tested

I tested all the new instruments that come with the synthesizer and mostly do sound good. I didn't notice any performance drop while playing. Wrenching and unwrenching the synth works. I'm going to upload some videos of it as well. (audio only)
campanella real.webm

Sprites

I have three different sprites for the synth, made by Blonichu, Burntdevil and Turnip. The synth will pick a random sprite when created.

Changelog

🆑

• rscadd: A new synthesizer with updated sounds has hit the market! Get it while you can!

[west3436]

Still working through this but aside from the controller issue I'm mainly just seeing style issues. General notes:

• Avoid same-line if's/for's/etc. The improved readability of splitting these into multiple lines is worth the added linecount.
• src.*** is being applied liberally here - you typically do not need to put src. before accessing/setting a var within scope of the var's owner. No need to correct the existing instances; it's just worth noting for the future.

[angryturnip]

The PR that saved /vg/station

[jwhitak]

Looking good, I only noticed one strange check and minor infractions of code readability. Not bad for a port. I'm still a little blind in the music math parts of the code. They seem to work correctly...