-
Notifications
You must be signed in to change notification settings - Fork 548
HOG! #37454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOG! #37454
Conversation
My prize... finally... |
I'll review on Monday unless West or someone beats me to it |
;HOG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise, this looks great. Only found a list index runtime. Besides that, I do want to make a few notes - none that would stop me from merging this when you unmark it from draft to confirm it's ready to go. The HOG is currently waiting for release.
- The movement of the running hog looks terrible, likely because of the slipping-through-airlocks acting as diagonal teleporting at an even faster speed than the dash movement. I've got no immediate solution to this... Here's an example of the issue:
fastdiagonalhog.webm
-
You already indicated this, but I'd like to confirm that the pork really should be increased. These things are sly AND tough! My testing with the hog netted me a whole 2 porks. Not a deal beaker, but how will a chef feed the crew on just that?
-
There are no lube-safe shoes in the code. Galoshes, no-slips, magshoes, etc, all kneel before the lube. We have a clothing flag for it, but it remains unused. This lead me to hilarious HOG testing antics and my ultimate surrender: testing as a ghost with proccalls. This isn't your problem, but I wanted to make a note of it.
Noted, I'll get to these sometime in the next few days. I think 12 meat seems to be fair for the amount of annoyance. And maybe lowering overall health on the boar since chasing it is such a hassle to kill. I think the lube annoyance is intended based on @angryturnip 's original request. Regarding the diagonal movement -- yes, I agree. Worse, diagonal movement means that boars will usually move around people rather than run them over (they CAN run them over, but only as a last resort). The problem for this is that I use ASTAR for locating a new home and it allows for diagonal movement. I briefly tried modifying ASTAR to make diagonal movement optional based on args... but that ended up breaking ASTAR. I don't want to completely refactor ASTAR but if someone ever adds orthogonal-only routing, that'd be great for this. |
Fixes addressed Reduced hog health by 33% (to 300) |
How the event works
🆑