Skip to content

Conversation

SECBATON-GRIFFON
Copy link
Contributor

@SECBATON-GRIFFON SECBATON-GRIFFON commented Mar 22, 2025

[dnm] until 516 is ready on this server

What this does

516 added vectors, later versions of it break compatiability with the helper functions, as they cannot overwrite this type
so, this makes the game compile on 516 and above, while removing redundant procs

Why it's good

game will continue to work on this version

How it was tested

TBA

@D3athrow-Issues D3athrow-Issues added the ✋ Do Not Merge ✋ Don't you do it. label Mar 22, 2025
@ShiftyRail
Copy link
Collaborator

ShiftyRail commented Apr 19, 2025

This is absolutely the wrong way to do it. Our /vector datum does a lot more than the baseline type in BYOND. I don't see the point in refactoring all that code to a strictly worse version. I don't believe performance on /vector procs & arithmetic is taxing enough to warrant this port.

In my opinion, we should simply rename /vector to /_vector and keep using it as usual.

Additionally, while this makes our code compilable, it does not fix other issues with a 516 compile : namely, a different behaviour for the overdark plane master and other issues with NanoUI.

@SECBATON-GRIFFON
Copy link
Contributor Author

This is absolutely the wrong way to do it. Our /vector datum does a lot more than the baseline type in BYOND. I don't see the point in refactoring all that code to a strictly worse version. I don't believe performance on /vector procs & arithmetic is taxing enough to warrant this port.

In my opinion, we should simply rename /vector to /_vector and keep using it as usual.

Additionally, while this makes our code compilable, it does not fix other issues with a 516 compile : namely, a different behaviour for the overdark plane master and other issues with NanoUI.

yea, i saw your PR go up just now with more fixes, so do i close this now with that in mind?

@ShiftyRail
Copy link
Collaborator

Yeah I think you can close this. My PR should be ready by Sunday. It's gonna be unreviewable but I plan to upload video evidence of our UIs working.

@SECBATON-GRIFFON SECBATON-GRIFFON deleted the vector-conversion branch April 25, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✋ Do Not Merge ✋ Don't you do it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants