Skip to content

516 compatibility PR 2: the revenge of Node.js #37501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 55 commits into from
May 6, 2025
Merged

516 compatibility PR 2: the revenge of Node.js #37501

merged 55 commits into from
May 6, 2025

Conversation

ShiftyRail
Copy link
Collaborator

@ShiftyRail ShiftyRail commented Apr 20, 2025 •
edited
Loading

This time with proper installation of TGUI & all that crap.

What this does

This makes the server compilable and playable in BYOND 516. This is a work in progress PR.

  • Convert /vector now-native type into a custom subtype to maintain all our features
  • Fix the overdark/darkness planes to render properly in 516. This causes MINOR features discrepency as I had to change the behaviour of dark_plane for people who wear night vision googles, for grues, and for spiders. The effect isn't directly noticeable.
  • Compile TGUI.
  • Fix TGUI interfaces. They straight up do not work in Chromium.
  • More testing maybe ?

Why it's good

516 liberates us from IE, is faster overall, is a more modern version of BYOND with more features, and has considerable rendering improvments. As a full disclosure I initially wanted to do this to test if Euro/vg/Lights were doable in this iteration of BYOND. They are, but they will be (if ever) the subject of a later PR.

How it was tested

Local test server compilation, some fiddling around with gameplay, test of TG/Nano/Raw HTML interfaces.

Nota Bene

This change would require all clients to migrate to 516 at the same time we migrate to 516 server-side ; the overdark changes would make the game unplayable on a non-515 client.

Changelog

🆑

  • experiment: Port the game to BYOND 516 for better features, in particular improved HTML UI responsiveness. Please report any bugs.

@ShiftyRail ShiftyRail added the System Modifies an underlying system within the game, may not affect players in any way. label Apr 20, 2025
@ShiftyRail
Copy link
Collaborator Author

So I've managed to fix TGUI compile, but now my interfaces throw an error/exception. I'll have to think about one way to solve this, but this is better than nothing, I suppose.

@ShiftyRail ShiftyRail added the WiP I'm not completely done yet! label Apr 20, 2025
ShiftyRail added 22 commits April 20, 2025 12:21
@ShiftyRail
TGUI try to fix #1
7f2166e
@ShiftyRail
Nuclear option. Bring all TGUI files. Will begin UNTGification in lat…
5738c90 
…er commits.
@ShiftyRail
Untgify: callback
876b33c
@ShiftyRail
untgify : config flags & config datums
6de8e35
@ShiftyRail
Fixes GLOBAL_VAR_INIT
ba693e7
@ShiftyRail
Purge HASTRAIT
b19c4f3
@ShiftyRail
.dme cleanup
08ad4bd
@ShiftyRail
file by file: status_alert.dm
f2c6b39
@ShiftyRail
file by file : preference datums + remove unused content
2c78dc5
@ShiftyRail
file by file : tgui_input/text.dm
fadc21e
@ShiftyRail
file by file : fixes asset_cache_client.dm
8bbca54
@ShiftyRail
file by file : tgui_panel / external.dm
8ee5a00
@ShiftyRail
file by file : tgui / external.dm
9ecd309
@ShiftyRail
file by file : tgui / states.dm
0947c37
@ShiftyRail
file by file : subsystems/assets.dm [unused return type]
c476030
@ShiftyRail
file by file : subsystems/tgui.dm [tg-macro for process()]
e2e941d
@ShiftyRail
file by file : asset_cache_item.dm [minor proc call fix]
92910e5
@ShiftyRail
file by file : fixes a mistype for datum/asset_cache_item
1c4f268
@ShiftyRail
file by file : removes bugs and unimplemented features in asset_list.dm
965b408
@ShiftyRail
multifile : some more work on asset manager
0d19474
@ShiftyRail
File deleted : spirtesheet tg_assets. Don't need them
94c2aea
@ShiftyRail
Remove unused TG content, fix asset_list.dm
12c8829
@ShiftyRail ShiftyRail mentioned this pull request Apr 26, 2025
Merged
@ShiftyRail
Copy link
Collaborator Author

image

One more

@ShiftyRail
Copy link
Collaborator Author

image

One more UI half-done, need to fix a bug related to sorting out the areas but it's close to working.

@ShiftyRail
Copy link
Collaborator Author

image

One more UI + some fixes along the way

@ShiftyRail
Copy link
Collaborator Author

image
image

And the final UI is done. Some bugs are still here but they were present before the 516 port and I don't want to spend time fighting them. Everyone that I have tested works mostly fine.

@ShiftyRail ShiftyRail added Unatomic Uncle Touches different things all at once. and removed WiP I'm not completely done yet! labels Apr 27, 2025
@ShiftyRail
Copy link
Collaborator Author

ShiftyRail commented Apr 27, 2025 •
edited
Loading

Units tests are failing because of cmp_list_by_element_desc. Interesting. Who the fuck wrote this code????????

@ShiftyRail ShiftyRail force-pushed the 516_but_it_will_work_this_time branch from e2e0606 to 7a485fb Compare April 27, 2025 16:54
@ShiftyRail
Copy link
Collaborator Author

This should be good to go now.

ShiftyRail
ShiftyRail commented May 1, 2025
View reviewed changes
.vscode/tasks.json Outdated
{
"type": "shell",
"command": "bin/tgui-build",
"command": "bin/tgui-build RUST_BACKTRACK=full",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix before merge

ShiftyRail
ShiftyRail commented May 1, 2025
View reviewed changes
__DEFINES/qdel.dm Outdated
#define QDEL_LIST_ASSOC_CUT(L) QDEL_LIST_ASSOC(L); L.Cut()

// QDEL macros borrowed from TG
#define QDELETED(X) (!X || !X || X.gcDestroyed)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix this is wrong

@ShiftyRail ShiftyRail mentioned this pull request May 3, 2025
Open
@d3athrow d3athrow merged commit 875eca8 into vgstation-coders:Bleeding-Edge May 6, 2025
5 checks passed
D3athrow-Issues added a commit that referenced this pull request May 6, 2025
@D3athrow-Issues
Automatic changelog generation for PR #37501 [ci skip]
be1141a
ShiftyRail added a commit to ShiftyRail/vgstation13 that referenced this pull request May 6, 2025
@ShiftyRail
Revert "516 compatibility PR 2: the revenge of Node.js (vgstation-cod…
e1f7abd 
…ers#37501)"

This reverts commit 875eca8.
d3athrow pushed a commit that referenced this pull request May 6, 2025
@ShiftyRail
Back to the drawing board (#37538)
b71b7b6 
* Revert "May fix the login failure issue on 516 (#37537)"

This reverts commit 6071b0a.

* Revert "516 compatibility PR 2: the revenge of Node.js (#37501)"

This reverts commit 875eca8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
System Modifies an underlying system within the game, may not affect players in any way. Unatomic Uncle Touches different things all at once.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShiftyRail @d3athrow @west3436