516 compatibility for simple HTML #37508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
BYOND 516 no longer let us send uncomplete HTML to render in browser window. Those instead get displayed as raw text.
This PR addresses that by adding a HTML wrapper to all
x<< browse(something, "window=x")
. This ensures they're properly displayed for a 516 client. The change is not noticeable by 515 clients.This PR is necessary for #37501 to work, but can be merged as a standalone into the Bleeding-Edge version. 515 clients won't notice anything. 516 clients will have less bugs.
We should, eventually, move away from uncomplete HTML and into browser datums as their code is a bit of a mess (to put it midly). It mixes UI and backend into the same file, it's not reactive, difficult to review, it looks a bit ugly, you need to close the window to see any changes, etc. But that's a lot of effort.
Why it's good
We want to move to 516 at some point.
How it was tested
Minimally if I'm honest. There's like, a hundred or so UIs to test? I just grabbed 2-3 of them and check if they still worked. They do. No problem.
Changelog
🆑