Misc Borg Bugfixes #38401
Open
Misc Borg Bugfixes #38401
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhitak
added
Bug / Fix
jwhitak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This PR solves an issue caused by opening multiple input windows at the same time. If you spammed the select module button as a borg, while you would receive the tools/sprite/etc of the first choice you make, the last choice in the flood of input windows is what you would count-as for purposes of borg module upgrades. This PR fixes this bug.
This PR also changes the wording of an incompatible upgrade, now clearly stating that the upgrade is incompatible, not just "it will not fit".
Finally, as a bonus because I don't want to make another PR, this fixes Borgs/MoMMis from being able to open TGUI-based computer consoles. This was broken by #37919 for two months and nobody reported it on github.
Why it's good
Fixes #38394.
How it was tested
Changelog
🆑