Skip to content

Conversation

SECBATON-GRIFFON
Copy link
Contributor

@SECBATON-GRIFFON SECBATON-GRIFFON commented Sep 19, 2025

[cleanup][consistency]

What this does

Reduces these duplicated verbs down to the object level, making them usable on alt click or right click if set as a variable.
Ports the functionality from railings and windows that allows alt click rotating items underneath if unrotatable to anything else, with suitable type checks.
Ports functionality from chairs to let ghost rotate objects, off on everything else by default but admins can enable it.
Suggestions for objects that could use them are welcome, by the way.
Puts a lot of stuff updated from these rotate verbs into change_dir() so they work elsewhere too.
Closes #16569. (but I could probably leave that in if people want it, one line change as mentoned above)

Why it's good

Allows coding this for more items to be much easier.

How it was tested

Putting windows down, fastening some, then alt click rotating some underneath, alt clicking emitters anchored and unanchored, creating pipes and disposal pipes with an RPD and rotating them, using the hobo shack, connecting an emitter to a beam and prism and then alt click rotating them by varediting rotates_anchored to be true.

Changelog

🆑

  • tweak: The rotate clockwise and counterclockwise verb on machinery no longer appears if the machine is anchored, more consistently.
  • rscadd: The MSGS, pressure tanks, freezers, heaters, mass driver frames, mannequins, windoor assemblies, mech bay recharge ports, beam mirrors and prisms, TEG parts, treadmills, wheelchair cannon assemblies, siege cannons, disposal pipe pieces and pod frame parts can be rotated on alt click, if unanchored where applicable to their verb.
  • bugfix: Ghosts or unconscious people can no longer rotate beam mirrors or prisms.
  • spellcheck: All formatting for object rotation failure via verb or alt click now formats as a warning.

@D3athrow-Issues D3athrow-Issues added the Consistency Issue This thing in question isn't consistent across multiple things. label Sep 19, 2025
@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review September 19, 2025 16:17
@SonixApache
Copy link
Contributor

SonixApache commented Sep 21, 2025

i swear if this breaks alt-clicking windows under grilles for the fourth time
did you test every single thing this affects?
did you test it in weird cases, like trying to rotate pipes under grilles and windows, or pipes you can't reach because there's a window in front?

@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as draft September 21, 2025 20:43
@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review September 21, 2025 21:04
@SECBATON-GRIFFON
Copy link
Contributor Author

SECBATON-GRIFFON commented Sep 21, 2025

i swear if this breaks alt-clicking windows under grilles for the fourth time

this works fine here

did you test it in weird cases, like trying to rotate pipes under grilles and windows, or pipes you can't reach because there's a window in front?

Adjacent() already handled all of that as normal

@hacker-on-steroids
Copy link
Contributor

finally, proper atmospherics/disposals alt-rotation(assuming it won't break other shit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Consistency Issue This thing in question isn't consistent across multiple things.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ghosts can Rotate Prisms
4 participants