fix(VgPlaybackButton): Added ChangeDetectorRef and called detectChang…#890
Open
vicatcu wants to merge 2 commits intovideogular:masterfrom
Open
fix(VgPlaybackButton): Added ChangeDetectorRef and called detectChang…#890vicatcu wants to merge 2 commits intovideogular:masterfrom
vicatcu wants to merge 2 commits intovideogular:masterfrom
Conversation
…es() in click handler I injected `public cdr: ChangeDetectorRef` into VgPlaybackButton and called `detectChanges()` as the last action in the `updatePlaybackSpeed()` method. This fixes videogular#845. I had to make some innocuous changes to some spec files to get it to build because of compile-time errors when running `npm run build`. 845
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I injected
public cdr: ChangeDetectorRefinto VgPlaybackButton and calleddetectChangesas the last action in theupdatePlaybackSpeed()method. This fixes #845. I had to make some innocuous changes to some spec files to get it to build because of compile-time errors when runningnpm run build.