fix: 🐛 Fix issue #810, seekbar doesn't go crazy when cursor out#917
Open
pyrextor wants to merge 1 commit intovideogular:masterfrom
Open
fix: 🐛 Fix issue #810, seekbar doesn't go crazy when cursor out#917pyrextor wants to merge 1 commit intovideogular:masterfrom
pyrextor wants to merge 1 commit intovideogular:masterfrom
Conversation
… out Fix issue videogular#810, seekbar doesn't go crazy when cursor is sliding the seekbar and gets out of the player. Instead getting offsetX, now get the cursor x coordinate and calculates its position relative to the scrub-bar to calculate the correct position. BREAKING CHANGE: 🧨 none ✅ Closes: videogular#810
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #810, seekbar doesn't go crazy when cursor is sliding the
seekbar and gets out of the player. Instead getting offsetX, now get the
cursor x coordinate and calculates its position relative to the
scrub-bar to calculate the correct position.
BREAKING CHANGE: 🧨 none
✅ Closes: #810
Description
Please explain the changes you made here. Commit your changes with
npm run commitinstead ofgit commit.Specify if it's a fix, feature or breaking change to update the version on NPM.
Thank you!
Checklist
Please, check that you have been followed next steps:
npm start)npm test)