Add support for getOr #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Also, fixed the handling for of 0 in the path because it was being rejected for being falsy |
Contributor
Author
|
I added code to fix #24 as well |
Owner
|
Thanks for the PR @daveisfera ! And sorry for super late reply. Looks like the tests are failing on this one. I've added github actions to the repo so by rebasing you'll see the results here too. |
Contributor
Author
|
I no longer have access to the codebase that I wrote this for, so I don't have a way to test/change anything with this PR. if you don't have the time/interest to fix it, then go ahead and close it. |
|
@villesau I'm gonna take a shot at getting this PR passing. Wish me luck. Thanks for making this codemod! |
This was referenced Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35