-
Notifications
You must be signed in to change notification settings - Fork 7
Fixes to Consensus Calling and Updated Depth Calculation #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zacherydickson
wants to merge
42
commits into
viromelab:master
Choose a base branch
from
zacherydickson:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added script fo filter incompataible variants from VCF file - Modified consensus calling scripts to use this filtering
Fixed Bug where TRACESPipe tried to save incorrectly named VCF Restructured VCF naming during consensus calling
alignments and cut off peaks at 1000
Also modified handling of sensitivity to reduce duplication of code Added git ignore for swp files
These changes moved to a branch This reverts commit 8d962be.
Changed VDB.fa in code to a variable for future maintainability
all branches of TRACESPipe (will use updated depth calcs)
virus REFTYPE swapped with viral depth calculation no longer inverted
This effectively converts all depth and breadth calculations to the non-supp/sec+maxDepth method
Fixed typos/language in some comments
Merging commits up from master
Update to match parent branch
Bring up typo fixed made in parent
Internal Viral Names System file created to track default supported viruses Viral Names in src dir now contains the set of viruses used in the analysis Removed all hardcoded viral lists
Removed blank line from internal viral names which leads to a fatal check for empty virus filtering scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes have been tested on two analysis runs.
Fixed a bug where called variants which are incompatible (eg. overlapping indel and snp) would lead to truncated consensus sequences.
The Bug was fixed by introducing a step where such incompatible variants are filtered out.
As samtools mileup is now no longer supported, consensus calling has been updated to use bcftools mpileup.
Depth of coverage calculation has been updated to use samtools bedcov, this allows ignoring excessively covered regions and automatically ignores secondary and supplementary reads which artificially inflate the depth.
Made a few changes to streamline and generalize code: