Skip to content

viogpu: Allow combining DBG and WPP #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

viogpu: Allow combining DBG and WPP #1332

wants to merge 1 commit into from

Conversation

akihikodaki
Copy link
Collaborator

Allow combining DBG and WPP by defining DBG and EVENT_TRACING at the same time.

@akihikodaki
viogpu: Allow combining DBG and WPP
96af220 
Allow combining DBG and WPP by defining DBG and EVENT_TRACING at the
same time.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
@YanVugenfirer
Copy link
Collaborator

Can one of the admins verify this patch?

@YanVugenfirer
Copy link
Collaborator

test this please

@ybendito
Copy link
Collaborator

@akihikodaki I have a question (just a question): What is the motivation to define both DBG and WPP?

@vrozenfe
Copy link
Collaborator

@akihikodaki @ybendito
Yeah, I also have the same question :)
IIRC, the original intention was to enable WPP in release builds and keep DBG for the developers, if they need it.
Did we change this approach recently?

All the best,
Vadim.

@akihikodaki
Copy link
Collaborator Author

@ybendito @vrozenfe My use case is to debug a detached Arm64 system.

Setting DBG gives logs via COM or vDbgPrintEx and enables debug assertions using VIOGPU_ASSERT_CHK. The logging does not work for a detached Arm64 system because:

  • IO ports used for COM are not available on Arm64.
  • vDbgPrintEx works only when attached.

Combining DBG and WPP allows having logging and debug assertions at the same time on a detached Arm64 system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YanVugenfirer YanVugenfirer YanVugenfirer approved these changes

@vrozenfe vrozenfe Awaiting requested review from vrozenfe vrozenfe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akihikodaki @YanVugenfirer @ybendito @vrozenfe