RHEL-50142: Add IO limits to the Windows Guest debugging tools [CI-NO-BUILD] #1347
Conversation
|
Can one of the admins verify this patch? |
Tools/debug/CollectSystemInfo.ps1
Outdated
| "x86" { $subdir = "x86" } | ||
| "x86_64" { $subdir = "amd64" } | ||
| "ia64" { $subdir = "amd64" } | ||
| default { $subdir = "amd64"; Write-Host "DEBUG: Unknown arch '$arch', defaulting to amd64" } |
There was a problem hiding this comment.
Write-Debug for debug messages, by this is more warning message than debug
Tools/debug/CollectSystemInfo.ps1
Outdated
| Write-Warning "diskspd.exe not available. Skipping IO Limits collection." | ||
| return | ||
| } | ||
| $lunDisks = Get-Disk |
There was a problem hiding this comment.
why lunDisks instead of disks?
Tools/debug/CollectSystemInfo.ps1
Outdated
|
|
||
| if (-not (Test-Path $diskspdExe)) { | ||
| if (-not (Test-Path $zipPath)) { | ||
| Write-Warning "DiskSpd.zip not found. Please place it next to the script." |
There was a problem hiding this comment.
- Currently, we need to provide 2 files for collecting logs. One of them is binary, so better to check the file checksum to make sure that it is not replaced with some
virus.zip - Update the README with information that DiskSpd.zip is required to be copied too.
@YanVugenfirer, what about downloading DiskSpd.zip from GitHub if it is not found, but an Internet connection is present?
There was a problem hiding this comment.
Why do we need diskspd? Maybe let's check what it does and add it to the script.
There was a problem hiding this comment.
diskspd uses DeviceIOControl to get IO information, it will be complicated to rewrite on powershell
Tools/debug/CollectSystemInfo.ps1
Outdated
|
|
||
| $diskspdExe = Join-Path $scriptDir 'diskspd.exe' | ||
| $zipPath = Join-Path $scriptDir 'DiskSpd.ZIP' | ||
| $extractDir = Join-Path $scriptDir 'DiskSpdExtracted' |
There was a problem hiding this comment.
Script is part of ISO, so $scriptDir is a read-only directory and you CAN'T extract files to it!
Tools/debug/CollectSystemInfo.ps1
Outdated
| } | ||
|
|
||
| $diskspdExe = Join-Path $scriptDir 'diskspd.exe' | ||
| $zipPath = Join-Path $scriptDir 'DiskSpd.ZIP' |
There was a problem hiding this comment.
@YanVugenfirer Do we need *pdb in the Zip archive, maybe remove it?
There was a problem hiding this comment.
Are those diskspd pdbs? Why do we need them? Are they needed for tracing?
There was a problem hiding this comment.
Are those diskspd pdbs?
Yes
Why do we need them?
It was in release artifact the same as we do for drivers
There was a problem hiding this comment.
I think, depending on the amount of functionality we need, we can either incorporate it in the script, download the diskspd from GitHub, or even build it (it is MIT licensed).
I think the only reason to have PDB for use for diskspd if for some reason we need the trace it produces.
kostyanf14
changed the title
Signed-off-by: Vitalii Chulak <vitalii@daynix.com>
Jedoku
force-pushed
the
RHEL-50142-Add-IO-limits-to-the-Windows-Guest-debugging-tools
branch
from
2bc8f2c to
2de2eea
Compare
|
\LogicalDisk(C:)\Disk Reads/sec: 145,87 IOPS |
RFC