Skip to content

Conversation

kumaranu
Copy link

This PR is to put allow the user to provide random seed values to keep the results consistent while testing.

There are two instances of random number generation in the code:

  1. geodesic_interpolate/interpolation.py
  2. geodesic_interpolate/coord_utils.py

The goal here is to only provide the seed value when the user wants to.

…in the code. This will make the results reproducible.
Copy link
Owner

@virtualzx-nad virtualzx-nad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding reproducibility support! A few suggestions:

  1. Consider using a single --seed parameter instead of two separate ones. The package can internally derive different seeds for different functions if needed.

  2. The help text could be more concise, e.g.:

    ps.add_argument("--seed", type=int, help="Random seed for reproducible results")
  3. The implementation part is missing - need to pass these seeds to the respective functions and set numpy's random seed.


Review by Augment, approved by user.

@kumaranu
Copy link
Author

kumaranu commented Jul 4, 2025

Thanks for adding reproducibility support! A few suggestions:

  1. Consider using a single --seed parameter instead of two separate ones. The package can internally derive different seeds for different functions if needed.
  2. The help text could be more concise, e.g.:
    ps.add_argument("--seed", type=int, help="Random seed for reproducible results")
  3. The implementation part is missing - need to pass these seeds to the respective functions and set numpy's random seed.

Review by Augment, approved by user.

Hi @virtualzx-nad ,
I have added my response. Also added a unit test to confirm that the seed reproduces the result. I added a github actions workflow, which is waiting for some approval. Please check if you could approve that. Thanks.

@virtualzx-nad virtualzx-nad self-requested a review July 18, 2025 13:53
@kumaranu
Copy link
Author

image Hi @virtualzx-nad, I have added a workflow file to run a test for the seed's validity. But that file needs approval here. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants