Fix React 19 Activity component support: preserve view state across hide/show cycles#10016
Open
Fix React 19 Activity component support: preserve view state across hide/show cycles#10016
Conversation
…ss hide/show cycles Co-authored-by: charlieforward9 <62311337+charlieforward9@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix React 19 Activity component support in deck.gl
Fix React 19 Activity component support: preserve view state across hide/show cycles
Feb 20, 2026
Collaborator
|
I imagine there is a cleaner way to do this in a future version that permanently changes the functionality but for now this would be backwards compatible |
Collaborator
|
I was wondering if the issue is isolated to viewState or if other props were resetting as well? |
Collaborator
|
I havent messed with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React 19's
<Activity>component preserves React state but runs effect cleanup/re-setup on hide/show, causing DeckGL to destroy and recreate its Deck instance — resettinginitialViewStateand losing user pan/zoom.Change List
finalize(), snapshotdeck.viewState(the internally-tracked uncontrolled view state) into asavedViewStatefield on the persistentthisRefsavedViewStateis set when the effect re-runs, pass it asinitialViewStateto the new Deck instance, then clear itdeck.viewStateisnullin controlled (props.viewState) mode, so the truthy check correctly skips restorationOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.