Skip to content

Improve intellisense for styles #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

yvbeek
Copy link

@yvbeek yvbeek commented May 16, 2020

Improves the type declarations to provide some autocomplete when you define the styles and when you use them.

Note: this will likely break code

  • The media-query definitions require as MediaQuery
  • You won't be able to refer to styles created under a media-query

If we want to further improve this, I believe the media-query mechanism would require an overhaul. The stylesheet definition is so dynamic at this point, that it becomes very hard to instruct the TypeScript transcompiler on what's correct and what isn't.

See #118 for more information.

@rafaelsaback
Copy link

Thanks for that one @yvbeek! I have already switched to your fork and I'm using it. I hope the PR gets merged soon 😉

@stale
Copy link

stale bot commented Jul 19, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jul 19, 2020
@stale stale bot closed this Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants