-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
feat(manifest): add assets field for standalone CSS entry points
#21015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manifest): add assets field for standalone CSS entry points
#21015
Conversation
The manifest.json file lists imported assets and CSS files per entry point, so the back end code can generate corresponding `<link rel=preload>` and `<link rel=stylesheet>`. These two manifest properties were missing for pure CSS entry points, if they weren't included by some other JavaScript entry point. See: vitejs#18392 (comment)
assets field for standalone CSS entry points
sapphi-red
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
…nks only (vitejs#21136)") into bugfix/imported-assets-dropped-for-standalone-pure-css-entry-points
|
I tried a quick update of this branch to v8.0.0-beta.1 but couldn't get it working yet. I found the I only pushed the conflict resolution for the docs for now and converted the PR to Draft since it doesn't work on version 8. |
|
The JS plugin is not called unless |
…ndalone-pure-css-entry-points v8.0.0-beta.3
…ndalone-pure-css-entry-points v8.0.0-beta.5
This is required for de4b1e4 ("fix(manifest): "assets" missing for standalone CSS entry points"). The assertion does not work without _VITE_TEST_JS_PLUGIN=1 because that requires sharing the metadata between rolldown (builtin:vite-manifest) and vite (vite:css-post).
|
Do you want to wait with the non- |
…ndalone-pure-css-entry-points v8.0.0-beta.8
|
@sapphi-red The parts of the native manifest related to |
I’ve polished up the native manifest part, thanks for your contribution. |
The manifest.json file lists imported assets and CSS files per entry point, so the back end code can generate corresponding
<link rel=preload>and<link rel=stylesheet>. These two manifest properties were missing for pure CSS entry points, if they weren't included by some other JavaScript entry point.See: #18392 (comment)