unions and structs are not translated correctly if typedef is not used

[dy-tea]

Here is some C code that uses unions:

#include <stdio.h>

int main() {
  union {
    int i;
    int j;
  } u;

  u.i = 3;
  u.j = 5;

  printf("%d, %d\n", u.i, u.j);

  return 0;
}

I run v translate test.c and it outputs the below test.v:

@[translated]
module main

fn main() {
	u.i = 3
	u.j = 5
	C.printf(c'%d, %d\n', u.i, u.j)
	return
}

The above code will not compile successfully, as u is not defined:

test.v:5:2: error: undefined ident: `u`
    3 | 
    4 | fn main() {
    5 |     u.i = 3
      |     ^
    6 |     u.j = 5
    7 |     C.printf(c'%d, %d\n', u.i, u.j)
test.v:5:4: error: `u` does not return a value
    3 | 
    4 | fn main() {
    5 |     u.i = 3
      |       ^
    6 |     u.j = 5
    7 |     C.printf(c'%d, %d\n', u.i, u.j)
test.v:5:4: error: unexpected symbol `void`
    3 | 
    4 | fn main() {
    5 |     u.i = 3
      |       ^
    6 |     u.j = 5
    7 |     C.printf(c'%d, %d\n', u.i, u.j)
test.v:6:2: error: undefined ident: `u`
    4 | fn main() {
    5 |     u.i = 3
    6 |     u.j = 5
      |     ^
    7 |     C.printf(c'%d, %d\n', u.i, u.j)
    8 |     return
test.v:6:4: error: `u` does not return a value
    4 | fn main() {
    5 |     u.i = 3
    6 |     u.j = 5
      |       ^
    7 |     C.printf(c'%d, %d\n', u.i, u.j)
    8 |     return
test.v:6:4: error: unexpected symbol `void`
    4 | fn main() {
    5 |     u.i = 3
    6 |     u.j = 5
      |       ^
    7 |     C.printf(c'%d, %d\n', u.i, u.j)
    8 |     return
test.v:7:24: error: undefined ident: `u`
    5 |     u.i = 3
    6 |     u.j = 5
    7 |     C.printf(c'%d, %d\n', u.i, u.j)
      |                           ^
    8 |     return
    9 | }
test.v:7:26: error: `u` does not return a value
    5 |     u.i = 3
    6 |     u.j = 5
    7 |     C.printf(c'%d, %d\n', u.i, u.j)
      |                             ^
    8 |     return
    9 | }

[JalonSolov]

Looks like it just skipped the union def altogether.

[dy-tea]

Another example is with the input code:

union MyUnion {
  int a;
  int b;
};

int main() {
  union MyUnion u;
  u.a = 10;
  u.b = 100;
  return 0;
}

The below code is generated:

@[translated]
module main

union MyUnion {
	a int
	b int
}

fn main() {
	u := Union
	MyUnion{}
	u.a = 10
	u.b = 100
	return
}

Which incorrectly sets u to Union instead of MyUnion{}.

The case which does work correctly is with:

typedef union {
  int a;
  int b;
}MyUnion;

int main() {
  MyUnion u;
  u.a = 10;
  u.b = 100;
  return 0;
}

Which correctly translates to:

@[translated]
module main

union MyUnion {
	a int
	b int
}

fn main() {
	u := MyUnion{}
	u.a = 10
	u.b = 100
	return
}

[JalonSolov]

So the missing typedef is the problem. Changed the title accordingly.

[dy-tea]

Seems to also affect structs.

Here is some C code that has a struct inside and outside main:

struct Outside {
  int a;
  int b;
};

int main() {
  struct Outside o;
  o.a = 1;
  o.b = 2;

  struct Inside {
    int a;
    int b;
  };
  struct Inside i;
  i.a = 3;
  i.b = 4;
}

The struct outside main is handled correctly, but the struct definition inside main is removed:

@[translated]
module main

struct Outside {
	a int
	b int
}

fn main() {
	o := Outside{}
	o.a = 1
	o.b = 2

	i := Inside{}
	i.a = 3
	i.b = 4
}

[JalonSolov]

Title updated to include both.