-
Notifications
You must be signed in to change notification settings - Fork 39
Support for targets and ignore in Sparsity Compressors
#182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kylesayrs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how/if this is related to #822 (it's listed as a dependency)
- Doesn't this list of targets need to be accounted for during decompression?
- Don't these changes throw away any weights which are not targeted for sparse compression?
src/compressed_tensors/compressors/model_compressors/model_compressor.py
Outdated
Show resolved
Hide resolved
src/compressed_tensors/compressors/model_compressors/model_compressor.py
Outdated
Show resolved
Hide resolved
src/compressed_tensors/compressors/model_compressors/model_compressor.py
Outdated
Show resolved
Hide resolved
400c6c3 to
e5bfd8a
Compare
Point 1: Decompression takes care of that using COMPRESSION_PARAM_NAMES It is listed as a dependency for #822 because without this we cannot enable sparse compression + quantization compression. These changes are needed for #822 to work fine. |
1a7cdba to
a528334
Compare
kylesayrs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ly.py Signed-off-by: Rahul Tuli <rahul@neuralmagic.com>
Add: tests for get_nested_weight_mappings Signed-off-by: Rahul Tuli <rahul@neuralmagic.com>
Signed-off-by: Rahul Tuli <rahul@neuralmagic.com>
9eeede7 to
f80a45e
Compare
This PR introduces support for using
targetsandignorein sparsity compressors. It has been tested against thellm-compressorrepository at commita47137d8(onmain).Changes Made
BaseSparsity.compress(...)methods to accept a newcompression_targetsargument.ModelCompressorto directly populate thecompression_targetsargument.Verification
The functionality was verified using the following script:
Verification Script
The script passes successfully without any assertions.
Script Output