Skip to content

Conversation

@dsikka
Copy link
Collaborator

@dsikka dsikka commented Nov 10, 2025

Summary

  • Update flakey test. Periodically produces NaNs - maybe from recently updating the dtype to bfloat16?
  • Don't cast zp back to dense dtype post rounding

@dsikka dsikka enabled auto-merge (squash) November 10, 2025 22:19
kylesayrs
kylesayrs previously approved these changes Nov 10, 2025
Copy link
Collaborator

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is a lot more correct and prevents any unintended effects on zero points.

We should consider also not casting to original dtype during quantize, but we can think about that more later.

https://github.com/vllm-project/compressed-tensors/blob/main/src/compressed_tensors/quantization/lifecycle/forward.py#L477-L479

@dsikka dsikka disabled auto-merge November 10, 2025 22:30
@dsikka dsikka merged commit f1f2304 into main Nov 10, 2025
3 checks passed
@dsikka dsikka deleted the small_fixes branch November 10, 2025 22:38
@dsikka dsikka mentioned this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants